[coreboot-gerrit] Change in ...coreboot[master]: mb/intel/icelake_rvp: Add support for ALPS touchpad

[Aamir Bohra (Code Review)]

Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29777


Change subject: mb/intel/icelake_rvp: Add support for ALPS touchpad
......................................................................

mb/intel/icelake_rvp: Add support for ALPS touchpad

Change-Id: I4085b70560e2840c71b989348f56ca907e7cea4b
Signed-off-by: Aamir Bohra <aamir.bohra at intel.com>
---
M src/mainboard/intel/icelake_rvp/variants/icl_u/devicetree.cb
M src/mainboard/intel/icelake_rvp/variants/icl_y/devicetree.cb
2 files changed, 18 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/29777/1

diff --git a/src/mainboard/intel/icelake_rvp/variants/icl_u/devicetree.cb b/src/mainboard/intel/icelake_rvp/variants/icl_u/devicetree.cb
index a57d91a..962a0cf 100644
--- a/src/mainboard/intel/icelake_rvp/variants/icl_u/devicetree.cb
+++ b/src/mainboard/intel/icelake_rvp/variants/icl_u/devicetree.cb
@@ -106,7 +106,15 @@
 			device pci 14.3 on  end # CNVi wifi
 		end
 		device pci 14.5 on  end # SDCard
-		device pci 15.0 on  end # I2C #0
+		device pci 15.0 on
+			chip drivers/i2c/hid
+				register "generic.hid" = ""ALPS0000""
+				register "generic.desc" = ""Touchpad""
+				register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C8_IRQ)"
+				register "hid_desc_reg_offset" = "0x20"
+				device i2c 2C on end
+			end
+		end # I2C 0
 		device pci 15.1 on  end # I2C #1
 		device pci 15.2 off end # I2C #2
 		device pci 15.3 on end # I2C #3
diff --git a/src/mainboard/intel/icelake_rvp/variants/icl_y/devicetree.cb b/src/mainboard/intel/icelake_rvp/variants/icl_y/devicetree.cb
index f8fbfb4..f3e74b5 100644
--- a/src/mainboard/intel/icelake_rvp/variants/icl_y/devicetree.cb
+++ b/src/mainboard/intel/icelake_rvp/variants/icl_y/devicetree.cb
@@ -90,7 +90,15 @@
 			device pci 14.3 on  end # CNVi wifi
 		end
 		device pci 14.5 on  end # SDCard
-		device pci 15.0 on  end # I2C 0
+		device pci 15.0 on
+			chip drivers/i2c/hid
+				register "generic.hid" = ""ALPS0000""
+				register "generic.desc" = ""Touchpad""
+				register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C8_IRQ)"
+				register "hid_desc_reg_offset" = "0x20"
+				device i2c 2C on end
+			end
+		end # I2C 0
 		device pci 15.1 on  end # I2C #1
 		device pci 15.2 off  end # I2C #2
 		device pci 15.3 on  end # I2C #3

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29777
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4085b70560e2840c71b989348f56ca907e7cea4b
Gerrit-Change-Number: 29777
Gerrit-PatchSet: 1
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181121/aec88b9a/attachment.html>