<p>Aamir Bohra has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/29777">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/intel/icelake_rvp: Add support for ALPS touchpad<br><br>Change-Id: I4085b70560e2840c71b989348f56ca907e7cea4b<br>Signed-off-by: Aamir Bohra <aamir.bohra@intel.com><br>---<br>M src/mainboard/intel/icelake_rvp/variants/icl_u/devicetree.cb<br>M src/mainboard/intel/icelake_rvp/variants/icl_y/devicetree.cb<br>2 files changed, 18 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/29777/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/intel/icelake_rvp/variants/icl_u/devicetree.cb b/src/mainboard/intel/icelake_rvp/variants/icl_u/devicetree.cb</span><br><span>index a57d91a..962a0cf 100644</span><br><span>--- a/src/mainboard/intel/icelake_rvp/variants/icl_u/devicetree.cb</span><br><span>+++ b/src/mainboard/intel/icelake_rvp/variants/icl_u/devicetree.cb</span><br><span>@@ -106,7 +106,15 @@</span><br><span>                   device pci 14.3 on  end # CNVi wifi</span><br><span>          end</span><br><span>          device pci 14.5 on  end # SDCard</span><br><span style="color: hsl(0, 100%, 40%);">-                device pci 15.0 on  end # I2C #0</span><br><span style="color: hsl(120, 100%, 40%);">+              device pci 15.0 on</span><br><span style="color: hsl(120, 100%, 40%);">+                    chip drivers/i2c/hid</span><br><span style="color: hsl(120, 100%, 40%);">+                          register "generic.hid" = ""ALPS0000""</span><br><span style="color: hsl(120, 100%, 40%);">+                           register "generic.desc" = ""Touchpad""</span><br><span style="color: hsl(120, 100%, 40%);">+                          register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C8_IRQ)"</span><br><span style="color: hsl(120, 100%, 40%);">+                         register "hid_desc_reg_offset" = "0x20"</span><br><span style="color: hsl(120, 100%, 40%);">+                           device i2c 2C on end</span><br><span style="color: hsl(120, 100%, 40%);">+                  end</span><br><span style="color: hsl(120, 100%, 40%);">+           end # I2C 0</span><br><span>          device pci 15.1 on  end # I2C #1</span><br><span>             device pci 15.2 off end # I2C #2</span><br><span>             device pci 15.3 on end # I2C #3</span><br><span>diff --git a/src/mainboard/intel/icelake_rvp/variants/icl_y/devicetree.cb b/src/mainboard/intel/icelake_rvp/variants/icl_y/devicetree.cb</span><br><span>index f8fbfb4..f3e74b5 100644</span><br><span>--- a/src/mainboard/intel/icelake_rvp/variants/icl_y/devicetree.cb</span><br><span>+++ b/src/mainboard/intel/icelake_rvp/variants/icl_y/devicetree.cb</span><br><span>@@ -90,7 +90,15 @@</span><br><span>                    device pci 14.3 on  end # CNVi wifi</span><br><span>          end</span><br><span>          device pci 14.5 on  end # SDCard</span><br><span style="color: hsl(0, 100%, 40%);">-                device pci 15.0 on  end # I2C 0</span><br><span style="color: hsl(120, 100%, 40%);">+               device pci 15.0 on</span><br><span style="color: hsl(120, 100%, 40%);">+                    chip drivers/i2c/hid</span><br><span style="color: hsl(120, 100%, 40%);">+                          register "generic.hid" = ""ALPS0000""</span><br><span style="color: hsl(120, 100%, 40%);">+                           register "generic.desc" = ""Touchpad""</span><br><span style="color: hsl(120, 100%, 40%);">+                          register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C8_IRQ)"</span><br><span style="color: hsl(120, 100%, 40%);">+                         register "hid_desc_reg_offset" = "0x20"</span><br><span style="color: hsl(120, 100%, 40%);">+                           device i2c 2C on end</span><br><span style="color: hsl(120, 100%, 40%);">+                  end</span><br><span style="color: hsl(120, 100%, 40%);">+           end # I2C 0</span><br><span>          device pci 15.1 on  end # I2C #1</span><br><span>             device pci 15.2 off  end # I2C #2</span><br><span>            device pci 15.3 on  end # I2C #3</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29777">change 29777</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29777"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4085b70560e2840c71b989348f56ca907e7cea4b </div>
<div style="display:none"> Gerrit-Change-Number: 29777 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Aamir Bohra <aamir.bohra@intel.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>