[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/icelake: Create macros for FSP consumption as per ICL requi...

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Tue Nov 20 23:41:51 CET 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29748 )

Change subject: soc/intel/icelake: Create macros for FSP consumption as per ICL requirement
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/29748/1/src/soc/intel/icelake/include/soc/serialio.h 
File src/soc/intel/icelake/include/soc/serialio.h:

https://review.coreboot.org/#/c/29748/1/src/soc/intel/icelake/include/soc/serialio.h@25 
PS1, Line 25:  } PCH_SERIAL_IO_MODE;
please, no spaces at the start of a line



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29748
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I524c7ed116aeb8b353123d7b1d9815b0f249d0e6
Gerrit-Change-Number: 29748
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 20 Nov 2018 22:41:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181120/5939639b/attachment.html>


More information about the coreboot-gerrit mailing list