[coreboot-gerrit] Change in coreboot[master]: mb/google/octopus: Set IOSSTATE to 9 for interrupt pins

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29645 )

Change subject: mb/google/octopus: Set IOSSTATE to 9 for interrupt pins
......................................................................


Patch Set 1:

(5 comments)

https://review.coreboot.org/#/c/29645/1/src/mainboard/google/octopus/variants/baseboard/gpio.c
File src/mainboard/google/octopus/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/29645/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@107
PS1, Line 107: 	PAD_CFG_GPI_APIC_IOS(GPIO_212, NONE, DEEP, LEVEL, INVERT, TxDRxE, DISPUPD), /* Touch Panel Int */
line over 80 characters


https://review.coreboot.org/#/c/29645/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@109
PS1, Line 109: 	PAD_CFG_GPI_APIC_IOS(GPIO_214, NONE, DEEP, LEVEL, INVERT, TxDRxE, DISPUPD), /* P_SENSOR_INT_L */
line over 80 characters


https://review.coreboot.org/#/c/29645/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@201
PS1, Line 201: 	PAD_CFG_GPI_APIC_IOS(GPIO_137, NONE, DEEP, LEVEL, INVERT, TxDRxE, DISPUPD),/* GPIO_137 -- HP_INT_ODL */
line over 80 characters


https://review.coreboot.org/#/c/29645/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@202
PS1, Line 202: 	PAD_CFG_GPI_APIC_IOS(GPIO_138, NONE, DEEP, LEVEL, INVERT, TxDRxE, DISPUPD),/* GPIO_138 -- PEN_PDCT_ODL */
line over 80 characters


https://review.coreboot.org/#/c/29645/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@203
PS1, Line 203: 	PAD_CFG_GPI_APIC_IOS(GPIO_139, NONE, DEEP, LEVEL, INVERT, TxDRxE, DISPUPD),/* GPIO_139 -- PEN_INT_ODL */
line over 80 characters



-- 
To view, visit https://review.coreboot.org/29645
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7fccf0656ffca8c212d2ccd168f53ed41887763
Gerrit-Change-Number: 29645
Gerrit-PatchSet: 1
Gerrit-Owner: Kane Chen <kane.chen at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 15 Nov 2018 08:12:15 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181115/b1cc8f5e/attachment.html>