<p><a href="https://review.coreboot.org/29645">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29645/1/src/mainboard/google/octopus/variants/baseboard/gpio.c">File src/mainboard/google/octopus/variants/baseboard/gpio.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29645/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@107">Patch Set #1, Line 107:</a> <code style="font-family:monospace,monospace">     PAD_CFG_GPI_APIC_IOS(GPIO_212, NONE, DEEP, LEVEL, INVERT, TxDRxE, DISPUPD), /* Touch Panel Int */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29645/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@109">Patch Set #1, Line 109:</a> <code style="font-family:monospace,monospace">   PAD_CFG_GPI_APIC_IOS(GPIO_214, NONE, DEEP, LEVEL, INVERT, TxDRxE, DISPUPD), /* P_SENSOR_INT_L */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29645/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@201">Patch Set #1, Line 201:</a> <code style="font-family:monospace,monospace">    PAD_CFG_GPI_APIC_IOS(GPIO_137, NONE, DEEP, LEVEL, INVERT, TxDRxE, DISPUPD),/* GPIO_137 -- HP_INT_ODL */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29645/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@202">Patch Set #1, Line 202:</a> <code style="font-family:monospace,monospace">     PAD_CFG_GPI_APIC_IOS(GPIO_138, NONE, DEEP, LEVEL, INVERT, TxDRxE, DISPUPD),/* GPIO_138 -- PEN_PDCT_ODL */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29645/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@203">Patch Set #1, Line 203:</a> <code style="font-family:monospace,monospace">   PAD_CFG_GPI_APIC_IOS(GPIO_139, NONE, DEEP, LEVEL, INVERT, TxDRxE, DISPUPD),/* GPIO_139 -- PEN_INT_ODL */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/29645">change 29645</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29645"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ib7fccf0656ffca8c212d2ccd168f53ed41887763 </div>
<div style="display:none"> Gerrit-Change-Number: 29645 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kane Chen <kane.chen@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 15 Nov 2018 08:12:15 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>