[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneridge: Add DRAM check for s3

Marshall Dawson (Code Review) gerrit at coreboot.org
Wed Nov 14 00:23:18 CET 2018


Hello build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/29406

to look at the new patch set (#4).

Change subject: soc/amd/stoneridge: Add DRAM check for s3
......................................................................

soc/amd/stoneridge: Add DRAM check for s3

Allocate cbmem space to store DRAM check data during S3.  Verify the
the data is unchanged during the resume.  Due to where the save and
verify steps are placed, the test cannot capture 100% of potential
memory corruption causes in coreboot.

The ranges to verify are determined by the coreboot tables that are
constructed at the end of POST.  If a failure occurs within RAM available
to the OS, the test reports "ERROR" to force suspend_stress_test to
stop.  Otherwise, the mismatch is reported as "FYI", e.g. in memory
owned by coreboot.

CAUTION: This test must not be deployed in a shipping system.  It
         disables TSEG, and its protections, in order to allow the
         performance to be at an acceptable level.
TODO:    Add the capability of checking DRAM above 4GB.

TEST=Suspend/resume grunt.  Verify mismatch with induced error.
BUG=b:118157730

Change-Id: I375dd7ea9a3ab8992f1616126bcbd9724e4fc9a0
Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
---
M src/soc/amd/common/block/pi/amd_resume_final.c
M src/soc/amd/stoneyridge/Kconfig
M src/soc/amd/stoneyridge/Makefile.inc
M src/soc/amd/stoneyridge/finalize.c
M src/soc/amd/stoneyridge/include/soc/iomap.h
A src/soc/amd/stoneyridge/include/soc/s3test_util.h
A src/soc/amd/stoneyridge/s3test_util.c
M src/soc/amd/stoneyridge/smihandler.c
8 files changed, 433 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/29406/4
-- 
To view, visit https://review.coreboot.org/29406
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I375dd7ea9a3ab8992f1616126bcbd9724e4fc9a0
Gerrit-Change-Number: 29406
Gerrit-PatchSet: 4
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181113/8576062c/attachment.html>


More information about the coreboot-gerrit mailing list