[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneridge: Add DRAM check for s3

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29406 )

Change subject: soc/amd/stoneridge: Add DRAM check for s3
......................................................................


Patch Set 3:

(6 comments)

https://review.coreboot.org/#/c/29406/3/src/soc/amd/stoneyridge/s3test_util.c
File src/soc/amd/stoneyridge/s3test_util.c:

https://review.coreboot.org/#/c/29406/3/src/soc/amd/stoneyridge/s3test_util.c@252
PS3, Line 252:   	wbinvd();
code indent should use tabs where possible


https://review.coreboot.org/#/c/29406/3/src/soc/amd/stoneyridge/s3test_util.c@252
PS3, Line 252:   	wbinvd();
please, no space before tabs


https://review.coreboot.org/#/c/29406/3/src/soc/amd/stoneyridge/s3test_util.c@252
PS3, Line 252:   	wbinvd();
please, no spaces at the start of a line


https://review.coreboot.org/#/c/29406/3/src/soc/amd/stoneyridge/s3test_util.c@254
PS3, Line 254:   	err = 0;
code indent should use tabs where possible


https://review.coreboot.org/#/c/29406/3/src/soc/amd/stoneyridge/s3test_util.c@254
PS3, Line 254:   	err = 0;
please, no space before tabs


https://review.coreboot.org/#/c/29406/3/src/soc/amd/stoneyridge/s3test_util.c@254
PS3, Line 254:   	err = 0;
please, no spaces at the start of a line



-- 
To view, visit https://review.coreboot.org/29406
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I375dd7ea9a3ab8992f1616126bcbd9724e4fc9a0
Gerrit-Change-Number: 29406
Gerrit-PatchSet: 3
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 13 Nov 2018 22:01:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181113/0c015db3/attachment.html>