[coreboot-gerrit] Change in coreboot[master]: soc/intel: Clean mess around UART_DEBUG

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/29573 )

Change subject: soc/intel: Clean mess around UART_DEBUG
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/29573/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/29573/1//COMMIT_MSG@10
PS1, Line 10: Based on Kconfig prompts the SoC code performed pad configu-
            : rations!
Which chipset? And what exactly were the bad configurations?


https://review.coreboot.org/#/c/29573/1/src/soc/intel/common/block/uart/Kconfig
File src/soc/intel/common/block/uart/Kconfig:

https://review.coreboot.org/#/c/29573/1/src/soc/intel/common/block/uart/Kconfig@20
PS1, Line 20: 	bool
We have 2 different builds with chromium. 1 with serial console and 1 w/o. By not making this option visible we can't select it with a local .config file.



-- 
To view, visit https://review.coreboot.org/29573
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2ed3cab0bb04bb23989c22da45299f088c758b
Gerrit-Change-Number: 29573
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin at gmail.com>
Gerrit-Comment-Date: Mon, 12 Nov 2018 18:23:04 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181112/644b1d90/attachment.html>