[coreboot-gerrit] Change in coreboot[master]: siemens/mc_apl4: Remove external RTC from I2C0
Werner Zeh (Code Review)
gerrit at coreboot.org
Mon Nov 12 08:27:25 CET 2018
Werner Zeh has submitted this change and it was merged. ( https://review.coreboot.org/29560 )
Change subject: siemens/mc_apl4: Remove external RTC from I2C0
......................................................................
siemens/mc_apl4: Remove external RTC from I2C0
This mainboard also has an external RTC chip, but not on this bus. The
topic is currently in clarification and will be published with a later
patch. In a first step we enable all I2C busses.
Change-Id: I9ec9631ed15ab30cc6a4594531521f4a1419ad00
Signed-off-by: Mario Scheithauer <mario.scheithauer at siemens.com>
Reviewed-on: https://review.coreboot.org/29560
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Werner Zeh <werner.zeh at siemens.com>
---
M src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb
1 file changed, 7 insertions(+), 21 deletions(-)
Approvals:
build bot (Jenkins): Verified
Werner Zeh: Looks good to me, approved
diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb
index 61e8c71..d03623a 100644
--- a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb
+++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb
@@ -68,27 +68,13 @@
device pci 14.1 on end # - RP 1 - PCIe-B 1
device pci 15.0 on end # - XHCI
device pci 15.1 off end # - XDCI
- device pci 16.0 on # - I2C 0
- # Enable external RTC chip
- chip drivers/i2c/rx6110sa
- register "pmon_sampling" = "PMON_SAMPL_256_MS"
- register "bks_on" = "0"
- register "bks_off" = "1"
- register "iocut_en" = "1"
- register "set_user_date" = "1"
- register "user_year" = "04"
- register "user_month" = "07"
- register "user_day" = "01"
- register "user_weekday" = "4"
- device i2c 0x32 on end # RTC RX6110 SA
- end
- end
- device pci 16.1 off end # - I2C 1
- device pci 16.2 off end # - I2C 2
- device pci 16.3 off end # - I2C 3
- device pci 17.0 off end # - I2C 4
- device pci 17.1 off end # - I2C 5
- device pci 17.2 off end # - I2C 6
+ device pci 16.0 on end # - I2C 0
+ device pci 16.1 on end # - I2C 1
+ device pci 16.2 on end # - I2C 2
+ device pci 16.3 on end # - I2C 3
+ device pci 17.0 on end # - I2C 4
+ device pci 17.1 on end # - I2C 5
+ device pci 17.2 on end # - I2C 6
device pci 17.3 on end # - I2C 7
device pci 18.0 on end # - UART 0
device pci 18.1 on end # - UART 1
--
To view, visit https://review.coreboot.org/29560
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ec9631ed15ab30cc6a4594531521f4a1419ad00
Gerrit-Change-Number: 29560
Gerrit-PatchSet: 3
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181112/0fe44ac4/attachment.html>
More information about the coreboot-gerrit
mailing list