[coreboot-gerrit] Change in coreboot[master]: mb/emulation/qemu-i440fx|q35: Get rid of unused headers

Patrick Rudolph (Code Review) gerrit at coreboot.org
Sun Nov 11 19:30:12 CET 2018


Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29577 )

Change subject: mb/emulation/qemu-i440fx|q35: Get rid of unused headers
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/29577/1/src/mainboard/emulation/qemu-i440fx/mainboard.c
File src/mainboard/emulation/qemu-i440fx/mainboard.c:

https://review.coreboot.org/#/c/29577/1/src/mainboard/emulation/qemu-i440fx/mainboard.c@21
PS1, Line 21: 
> ah, true that
I'd like to have a single header for those functions, but it requires touching 50% of coreboot's x86 code...



-- 
To view, visit https://review.coreboot.org/29577
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cf0e4ef5b090d15ad823747fcf9219644e130fc
Gerrit-Change-Number: 29577
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 11 Nov 2018 18:30:12 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181111/58f3f2e8/attachment.html>


More information about the coreboot-gerrit mailing list