[coreboot-gerrit] Change in coreboot[master]: src/arch/x86/acpi.c: Update ACPI table revisions

Elyes HAOUAS (Code Review) gerrit at coreboot.org
Sun Nov 11 15:23:49 CET 2018


Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/29579


Change subject: src/arch/x86/acpi.c: Update ACPI table revisions
......................................................................

src/arch/x86/acpi.c: Update ACPI table revisions

Change-Id: I22020bd156536ee8f23a267d7c7b2d7af6c7cfeb
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/arch/x86/acpi.c
1 file changed, 7 insertions(+), 7 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/29579/1

diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c
index f54aa19..6d3c068 100644
--- a/src/arch/x86/acpi.c
+++ b/src/arch/x86/acpi.c
@@ -1328,9 +1328,9 @@
 {
 	switch (table) {
 	case FADT:
-		return ACPI_FADT_REV_ACPI_3_0;
-	case MADT: /* ACPI 1.0/2.0: 1, ACPI 3.0: 2, ACPI 4.0: 3 */
-		return 2;
+		return ACPI_FADT_REV_ACPI_6_0;
+	case MADT: /* ACPI 1.0/2.0: 1, ACPI 3.0: 2, ACPI 4.0/5.0: 3 */
+		return 3; // ACPI 6.2a: 45 ?
 	case MCFG:
 		return 1;
 	case TCPA:
@@ -1339,8 +1339,8 @@
 		return 4;
 	case SSDT: /* ACPI 1.0/2.0: ?, ACPI 3.0/4.0: 2 */
 		return 2;
-	case SRAT:  /* ACPI 1.0: N/A, 2.0: 1, 3.0: 2, 4.0: 3 */
-		return 1; /* TODO Should probably be upgraded to 2 */
+	case SRAT:  /* ACPI 1.0: N/A, 2.0: 1, 3.0: 2, 4.0/5.0/6.2a: 3 */
+		return 3;
 	case DMAR:
 		return 1;
 	case SLIT:  /* ACPI 1.0: N/A, ACPI 2.0/3.0/4.0: 1 */
@@ -1354,12 +1354,12 @@
 	case DBG2:
 		return 0;
 	case FACS: /* ACPI 1.0: 0, ACPI 2.0/3.0: 1, ACPI 4.0: 2 */
-		return 1;
+		return 0;
 	case RSDT: /* ACPI 1.0/2.0/3.0/4.0: 1 */
 		return 1;
 	case XSDT: /* ACPI 1.0: N/A, 2.0/3.0/4.0: 1 */
 		return 1;
-	case RSDP:  /* ACPI 1.0: 0, ACPI 2.0/3.0/4.0: 2. */
+	case RSDP:  /* ACPI 1.0: 0, ACPI 2.0/3.0/4.0/5.0/6.2a: 2 */
 		return 2;
 	case HEST:
 		return 1;

-- 
To view, visit https://review.coreboot.org/29579
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I22020bd156536ee8f23a267d7c7b2d7af6c7cfeb
Gerrit-Change-Number: 29579
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181111/48caa069/attachment.html>


More information about the coreboot-gerrit mailing list