[coreboot-gerrit] Change in coreboot[master]: siemens/mc_apl3: Set Full Reset Bit into Reset Control Register

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/29530 )

Change subject: siemens/mc_apl3: Set Full Reset Bit into Reset Control Register
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/29530/1/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c
File src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c:

https://review.coreboot.org/#/c/29530/1/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c@67
PS1, Line 67: into
in


https://review.coreboot.org/#/c/29530/1/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c@68
PS1, Line 68: 	 * When Bit 3 is set to 1 the PCH will driving SLP_S3 active (low).
Maybe add:
...SLP_S3 active (low) when the reset button is pressed.
SLP_S3 is then used on the mainboard to generate the right reset timing.


https://review.coreboot.org/#/c/29530/1/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c@68
PS1, Line 68: driving
drive



-- 
To view, visit https://review.coreboot.org/29530
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib842f15b6ba14851d7f9b1b97c83389adc61f50b
Gerrit-Change-Number: 29530
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 08 Nov 2018 05:48:20 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181108/b214a115/attachment.html>