[coreboot-gerrit] Change in coreboot[master]: ec/google/chromeec: add support for retrieving OEM name

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Thu Nov 8 04:56:26 CET 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29497 )

Change subject: ec/google/chromeec: add support for retrieving OEM name
......................................................................


Patch Set 7:

(2 comments)

https://review.coreboot.org/#/c/29497/7/src/ec/google/chromeec/ec.c
File src/ec/google/chromeec/ec.c:

https://review.coreboot.org/#/c/29497/7/src/ec/google/chromeec/ec.c@614
PS7, Line 614: static int google_chromeec_cbi_get_string(char *buf, size_t bufsize, uint32_t tag)
line over 80 characters


https://review.coreboot.org/#/c/29497/7/src/ec/google/chromeec/ec.c@641
PS7, Line 641: 	return google_chromeec_cbi_get_string(buf, bufsize, CBI_TAG_DRAM_PART_NUM);
line over 80 characters



-- 
To view, visit https://review.coreboot.org/29497
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4938c4d60fcad9e1f43ef69cc4441d1653de7e24
Gerrit-Change-Number: 29497
Gerrit-PatchSet: 7
Gerrit-Owner: Wisley Chen <wisley.chen at quantatw.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Wisley Chen <wisley.chen at quanta.corp-partner.google.com>
Gerrit-Reviewer: Wisley Chen <wisley.chen at quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin at chromium.org>
Gerrit-CC: Furquan Shaikh <furquan at google.com>
Gerrit-CC: Jett Rink <jettrink at chromium.org>
Gerrit-Comment-Date: Thu, 08 Nov 2018 03:56:26 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181108/46604ff5/attachment.html>


More information about the coreboot-gerrit mailing list