[coreboot-gerrit] Change in coreboot[master]: ec/google/chromeec: add support for retrieving OEM name

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29497 )

Change subject: ec/google/chromeec: add support for retrieving OEM name
......................................................................


Patch Set 1:

(11 comments)

https://review.coreboot.org/#/c/29497/1/src/ec/google/chromeec/ec.c
File src/ec/google/chromeec/ec.c:

https://review.coreboot.org/#/c/29497/1/src/ec/google/chromeec/ec.c@641
PS1, Line 641:         struct ec_params_get_cbi p = {
code indent should use tabs where possible


https://review.coreboot.org/#/c/29497/1/src/ec/google/chromeec/ec.c@641
PS1, Line 641:         struct ec_params_get_cbi p = {
please, no spaces at the start of a line


https://review.coreboot.org/#/c/29497/1/src/ec/google/chromeec/ec.c@642
PS1, Line 642: 	        .tag = CBI_TAG_OEM_NAME,
code indent should use tabs where possible


https://review.coreboot.org/#/c/29497/1/src/ec/google/chromeec/ec.c@645
PS1, Line 645: 	        .cmd_code = EC_CMD_GET_CROS_BOARD_INFO,
code indent should use tabs where possible


https://review.coreboot.org/#/c/29497/1/src/ec/google/chromeec/ec.c@646
PS1, Line 646: 	        .cmd_version = 0,
code indent should use tabs where possible


https://review.coreboot.org/#/c/29497/1/src/ec/google/chromeec/ec.c@647
PS1, Line 647: 	        .cmd_data_in = &p,
code indent should use tabs where possible


https://review.coreboot.org/#/c/29497/1/src/ec/google/chromeec/ec.c@648
PS1, Line 648: 	        .cmd_data_out = buf,
code indent should use tabs where possible


https://review.coreboot.org/#/c/29497/1/src/ec/google/chromeec/ec.c@649
PS1, Line 649: 	        .cmd_size_in = sizeof(p),
code indent should use tabs where possible


https://review.coreboot.org/#/c/29497/1/src/ec/google/chromeec/ec.c@650
PS1, Line 650: 	        .cmd_size_out = bufsize,
code indent should use tabs where possible


https://review.coreboot.org/#/c/29497/1/src/ec/google/chromeec/ec.c@655
PS1, Line 655: 	if (rv < 0)
suspect code indent for conditional statements (8, 15)


https://review.coreboot.org/#/c/29497/1/src/ec/google/chromeec/ec.c@656
PS1, Line 656: 	       return rv;
Statements should start on a tabstop



-- 
To view, visit https://review.coreboot.org/29497
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4938c4d60fcad9e1f43ef69cc4441d1653de7e24
Gerrit-Change-Number: 29497
Gerrit-PatchSet: 1
Gerrit-Owner: Wisley Chen <wisley.chen at quantatw.com>
Gerrit-Reviewer: Wisley Chen <wisley.chen at quanta.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 06 Nov 2018 08:17:30 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181106/74f6ffb9/attachment.html>