[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variant/atlas: config GPP_F10 to use PLTRST

Nick Vaccaro (Code Review) gerrit at coreboot.org
Wed Nov 7 22:20:56 CET 2018


Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/29540


Change subject: mb/google/poppy/variant/atlas: config GPP_F10 to use PLTRST
......................................................................

mb/google/poppy/variant/atlas: config GPP_F10 to use PLTRST

GPIO's that use GPI_APIC setting with DEEP causes an IRQ storm after
S3 resume. GPIOs that fire IRQs via IOAPIC need to get their logic
reset over PLTRST to prevent IRQ storm after S3 resume and hence
configuring GPP_F10 (HP_IRQ_GPIO) to use PLTRST.

BUG=none
TEST=none

Change-Id: Idc6c42cb4dc6e8eb368d605c83f584f4c69077dc
Signed-off-by: Nick Vaccaro <nvaccaro at google.com>
---
M src/mainboard/google/poppy/variants/atlas/gpio.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/29540/1

diff --git a/src/mainboard/google/poppy/variants/atlas/gpio.c b/src/mainboard/google/poppy/variants/atlas/gpio.c
index 58f7fc5..02c145c 100644
--- a/src/mainboard/google/poppy/variants/atlas/gpio.c
+++ b/src/mainboard/google/poppy/variants/atlas/gpio.c
@@ -273,7 +273,7 @@
 	/* F9  : I2C4_SCL ==> PCH_I2C4_AUDIO_1V8_SCL */
 	PAD_CFG_NF_1V8(GPP_F9, NONE, DEEP, NF1),
 	/* F10 : I2C5_SDA ==> HP_IRQ_GPIO */
-	PAD_CFG_GPI_APIC(GPP_F10, 20K_PU, DEEP),
+	PAD_CFG_GPI_APIC(GPP_F10, 20K_PU, PLTRST),
 	/* F11 : I2C5_SCL ==> SPKR_RST_L */
 	PAD_CFG_GPO(GPP_F11, 1, RSMRST),
 	/* F12 : EMMC_CMD */

-- 
To view, visit https://review.coreboot.org/29540
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc6c42cb4dc6e8eb368d605c83f584f4c69077dc
Gerrit-Change-Number: 29540
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181107/7fa835af/attachment.html>


More information about the coreboot-gerrit mailing list