[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variant/nocturne: configure SAR irqs to use PLTRST

Nick Vaccaro (Code Review) gerrit at coreboot.org
Wed Nov 7 21:38:23 CET 2018


Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/29538


Change subject: mb/google/poppy/variant/nocturne: configure SAR irqs to use PLTRST
......................................................................

mb/google/poppy/variant/nocturne: configure SAR irqs to use PLTRST

GPIO's that use GPI_APIC setting with DEEP causes an IRQ storm after
S3 resume. GPIOs that fire IRQs via IOAPIC need to get their logic
reset over PLTRST to prevent IRQ strom after S3 resume and hence
configuring GPP_D9 and GPP_D10 to use PLTRST.

BUG=b:119202293
TEST=none

Change-Id: I98d71100f28fb9bae05db3fb7d9afcb3f81beb43
Signed-off-by: Nick Vaccaro <nvaccaro at google.com>
---
M src/mainboard/google/poppy/variants/nocturne/gpio.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/29538/1

diff --git a/src/mainboard/google/poppy/variants/nocturne/gpio.c b/src/mainboard/google/poppy/variants/nocturne/gpio.c
index 9aa7706..70b748b 100644
--- a/src/mainboard/google/poppy/variants/nocturne/gpio.c
+++ b/src/mainboard/google/poppy/variants/nocturne/gpio.c
@@ -180,9 +180,9 @@
 	/* D8  : ISH_I2C1_SCL ==> NC */
 	PAD_CFG_NC(GPP_D8),
 	/* D9  : ISH_SPI_CS# ==> PCH_SR1_INT_L */
-	PAD_CFG_GPI_APIC(GPP_D9, NONE, DEEP),
+	PAD_CFG_GPI_APIC(GPP_D9, NONE, PLTRST),
 	/* D10 : ISH_SPI_CLK ==> PCH_SR0_INT_L */
-	PAD_CFG_GPI_APIC(GPP_D10, NONE, DEEP),
+	PAD_CFG_GPI_APIC(GPP_D10, NONE, PLTRST),
 	/* D11 : ISH_SPI_MISO ==> NC */
 	PAD_CFG_NC(GPP_D11),
 	/* D12 : ISH_SPI_MOSI ==> NC */

-- 
To view, visit https://review.coreboot.org/29538
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I98d71100f28fb9bae05db3fb7d9afcb3f81beb43
Gerrit-Change-Number: 29538
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181107/dd608909/attachment.html>


More information about the coreboot-gerrit mailing list