[coreboot-gerrit] Change in coreboot[master]: mb/google/kahlee: edp panel initialization time tuning

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29469 )

Change subject: mb/google/kahlee: edp panel initialization time tuning
......................................................................


Patch Set 6:

(5 comments)

Sorry I did not noticed the other issues in the commit message... The explanation on commit message is now clear, thanks.

https://review.coreboot.org/#/c/29469/6//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/29469/6//COMMIT_MSG@7
PS6, Line 7: e
Capital letter


https://review.coreboot.org/#/c/29469/6//COMMIT_MSG@9
PS6, Line 9: a
Capital letter


https://review.coreboot.org/#/c/29469/6//COMMIT_MSG@12
PS6, Line 12: t
Capital letter


https://review.coreboot.org/#/c/29469/6//COMMIT_MSG@17
PS6, Line 17: emerge-grunt coreboot
Add a dot to the end.


https://review.coreboot.org/#/c/29469/6/src/soc/amd/stoneyridge/chip.h
File src/soc/amd/stoneyridge/chip.h:

https://review.coreboot.org/#/c/29469/6/src/soc/amd/stoneyridge/chip.h@67
PS6, Line 67: 	 * This specifies the LVDS/eDP power up sequence time for the delay from
            : 	 * active to active.
            : 	 * 0 - Use the VBIOS default (default). The video BIOS default is 32ms.
            : 	 * n - Values other than zero specify a setting of (4 * n) milliseconds
            : 	 *     time delay.
            : 
Nice, I like it.



-- 
To view, visit https://review.coreboot.org/29469
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib20c48813b208d697b950b2f02a70a690e483fdb
Gerrit-Change-Number: 29469
Gerrit-PatchSet: 6
Gerrit-Owner: chris wang <Chris.Wang at amd.com>
Gerrit-Reviewer: Chris Wang <chris.wang at amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: chris wang <Chris.Wang at amd.com>
Gerrit-Comment-Date: Tue, 06 Nov 2018 15:46:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181106/419b2684/attachment.html>