[coreboot-gerrit] Change in coreboot[master]: mb/google/kahlee: edp panel initialization time tuning

[chris wang (Code Review)]

chris wang has posted comments on this change. ( https://review.coreboot.org/29469 )

Change subject: mb/google/kahlee: edp panel initialization time tuning
......................................................................


Patch Set 6:

(2 comments)

Thank you Richard.

https://review.coreboot.org/#/c/29469/4//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/29469/4//COMMIT_MSG@12
PS4, Line 12: M is controlled by APU_EDP_BK
> This makes no sense with the actual code change. […]
correct the description and put more explanation here.


https://review.coreboot.org/#/c/29469/4/src/soc/amd/stoneyridge/chip.h
File src/soc/amd/stoneyridge/chip.h:

https://review.coreboot.org/#/c/29469/4/src/soc/amd/stoneyridge/chip.h@66
PS4, Line 66: 	/*
            : 	 * This specifies the LVDS/eDP power up sequence time for the delay from
            : 	
> I see in subsequent patch that it's unit of 4 milliseconds. Add that information here.
put more description here.



-- 
To view, visit https://review.coreboot.org/29469
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib20c48813b208d697b950b2f02a70a690e483fdb
Gerrit-Change-Number: 29469
Gerrit-PatchSet: 6
Gerrit-Owner: chris wang <Chris.Wang at amd.com>
Gerrit-Reviewer: Chris Wang <chris.wang at amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: chris wang <Chris.Wang at amd.com>
Gerrit-Comment-Date: Tue, 06 Nov 2018 09:09:24 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181106/30b5685a/attachment.html>