[coreboot-gerrit] Change in coreboot[master]: x86/acpi.c: Be more verbose when finding the wakeup vector

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/29449 )

Change subject: x86/acpi.c: Be more verbose when finding the wakeup vector
......................................................................

x86/acpi.c: Be more verbose when finding the wakeup vector

Since S3 resume sometimes breaks when trying to find the wakeup vector,
it is useful to log whether it errors or not. Since it is an error,
print it as such.

Change-Id: Ib006c4a213c0da180018e5fbf7a47d6af66f8bc4
Signed-off-by: Angel Pons <th3fanbus at gmail.com>
Reviewed-on: https://review.coreboot.org/29449
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Nico Huber <nico.h at gmx.de>
---
M src/arch/x86/acpi.c
1 file changed, 10 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved



diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c
index 24db7c0..f54aa19 100644
--- a/src/arch/x86/acpi.c
+++ b/src/arch/x86/acpi.c
@@ -1278,8 +1278,11 @@
 			break;
 	}
 
-	if (rsdp == NULL)
+	if (rsdp == NULL) {
+		printk(BIOS_ALERT,
+		       "No RSDP found, wake up from S3 not possible.\n");
 		return NULL;
+	}
 
 	printk(BIOS_DEBUG, "RSDP found at %p\n", rsdp);
 	rsdt = (acpi_rsdt_t *)(uintptr_t)rsdp->rsdt_address;
@@ -1294,15 +1297,18 @@
 		fadt = NULL;
 	}
 
-	if (fadt == NULL)
+	if (fadt == NULL) {
+		printk(BIOS_ALERT,
+		       "No FADT found, wake up from S3 not possible.\n");
 		return NULL;
+	}
 
 	printk(BIOS_DEBUG, "FADT found at %p\n", fadt);
 	facs = (acpi_facs_t *)(uintptr_t)fadt->firmware_ctrl;
 
 	if (facs == NULL) {
-		printk(BIOS_DEBUG, "No FACS found, wake up from S3 not "
-		       "possible.\n");
+		printk(BIOS_ALERT,
+		       "No FACS found, wake up from S3 not possible.\n");
 		return NULL;
 	}
 

-- 
To view, visit https://review.coreboot.org/29449
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib006c4a213c0da180018e5fbf7a47d6af66f8bc4
Gerrit-Change-Number: 29449
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181106/948a8e5c/attachment.html>