<p>Patrick Georgi <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/29449">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">x86/acpi.c: Be more verbose when finding the wakeup vector<br><br>Since S3 resume sometimes breaks when trying to find the wakeup vector,<br>it is useful to log whether it errors or not. Since it is an error,<br>print it as such.<br><br>Change-Id: Ib006c4a213c0da180018e5fbf7a47d6af66f8bc4<br>Signed-off-by: Angel Pons <th3fanbus@gmail.com><br>Reviewed-on: https://review.coreboot.org/29449<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Nico Huber <nico.h@gmx.de><br>---<br>M src/arch/x86/acpi.c<br>1 file changed, 10 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c</span><br><span>index 24db7c0..f54aa19 100644</span><br><span>--- a/src/arch/x86/acpi.c</span><br><span>+++ b/src/arch/x86/acpi.c</span><br><span>@@ -1278,8 +1278,11 @@</span><br><span>                   break;</span><br><span>       }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   if (rsdp == NULL)</span><br><span style="color: hsl(120, 100%, 40%);">+     if (rsdp == NULL) {</span><br><span style="color: hsl(120, 100%, 40%);">+           printk(BIOS_ALERT,</span><br><span style="color: hsl(120, 100%, 40%);">+                   "No RSDP found, wake up from S3 not possible.\n");</span><br><span>          return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+  }</span><br><span> </span><br><span>        printk(BIOS_DEBUG, "RSDP found at %p\n", rsdp);</span><br><span>    rsdt = (acpi_rsdt_t *)(uintptr_t)rsdp->rsdt_address;</span><br><span>@@ -1294,15 +1297,18 @@</span><br><span>            fadt = NULL;</span><br><span>         }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   if (fadt == NULL)</span><br><span style="color: hsl(120, 100%, 40%);">+     if (fadt == NULL) {</span><br><span style="color: hsl(120, 100%, 40%);">+           printk(BIOS_ALERT,</span><br><span style="color: hsl(120, 100%, 40%);">+                   "No FADT found, wake up from S3 not possible.\n");</span><br><span>          return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+  }</span><br><span> </span><br><span>        printk(BIOS_DEBUG, "FADT found at %p\n", fadt);</span><br><span>    facs = (acpi_facs_t *)(uintptr_t)fadt->firmware_ctrl;</span><br><span> </span><br><span>         if (facs == NULL) {</span><br><span style="color: hsl(0, 100%, 40%);">-             printk(BIOS_DEBUG, "No FACS found, wake up from S3 not "</span><br><span style="color: hsl(0, 100%, 40%);">-                     "possible.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+              printk(BIOS_ALERT,</span><br><span style="color: hsl(120, 100%, 40%);">+                   "No FACS found, wake up from S3 not possible.\n");</span><br><span>          return NULL;</span><br><span>         }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29449">change 29449</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29449"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ib006c4a213c0da180018e5fbf7a47d6af66f8bc4 </div>
<div style="display:none"> Gerrit-Change-Number: 29449 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>