[coreboot-gerrit] Change in coreboot[master]: ish: enable ISH in Fircrest

Li1 Feng (Code Review) gerrit at coreboot.org
Tue Nov 6 01:43:44 CET 2018


Li1 Feng has uploaded this change for review. ( https://review.coreboot.org/29491


Change subject: ish: enable ISH in Fircrest
......................................................................

ish: enable ISH in Fircrest

WIP: not merge.

In Fircrest enabled C12, C13 NF1 for ISH UART1

Change-Id: If171036218b15e16c288127ba925857221cabf60
Signed-off-by: li feng <li1.feng at intel.com>
---
M src/mainboard/google/sarien/variants/arcada/devicetree.cb
M src/mainboard/google/sarien/variants/arcada/gpio.c
2 files changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/29491/1

diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb
index e3b9680..342adbf 100644
--- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb
+++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb
@@ -108,6 +108,7 @@
 		device pci 12.0 on  end # Thermal Subsystem
 		device pci 12.5 off end # UFS SCS
 		device pci 12.6 off end # GSPI #2
+		device pci 13.0 on  end # ISH
 		device pci 14.0 on  end # USB xHCI
 		device pci 14.1 off end # USB xDCI (OTG)
 		device pci 14.5 off end # SDCard
diff --git a/src/mainboard/google/sarien/variants/arcada/gpio.c b/src/mainboard/google/sarien/variants/arcada/gpio.c
index eb4ee76..a5440a0 100644
--- a/src/mainboard/google/sarien/variants/arcada/gpio.c
+++ b/src/mainboard/google/sarien/variants/arcada/gpio.c
@@ -81,9 +81,8 @@
 /* UART0_TXD */		PAD_NC(GPP_C9, NONE),
 /* UART0_RTS# */	PAD_CFG_GPI(GPP_C10, NONE, DEEP), /* TYPEC_CON_SEL1 */
 /* UART0_CTS# */	PAD_CFG_GPI(GPP_C11, NONE, DEEP), /* TYPEC_CON_SEL2 */
-/* UART1_RXD */         PAD_CFG_GPI_SCI_LOW(GPP_C12, NONE, DEEP,
-				    EDGE_SINGLE), /* SIO_EXT_WAKE# */
-/* UART1_TXD */		PAD_NC(GPP_C13, NONE),
+/* UART1_RXD */		PAD_CFG_NF(GPP_C12, NONE, DEEP, NF1),
+/* UART1_TXD */		PAD_CFG_NF(GPP_C13, NONE, DEEP, NF1),
 /* UART1_RTS# */	PAD_CFG_GPI(GPP_C14, NONE, DEEP), /* LCD_CBL_DET# */
 /* UART1_CTS# */	PAD_NC(GPP_C15, NONE),
 /* I2C0_SDA */		PAD_CFG_NF(GPP_C16, NONE, DEEP, NF1), /* TS_I2C_SDA */

-- 
To view, visit https://review.coreboot.org/29491
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If171036218b15e16c288127ba925857221cabf60
Gerrit-Change-Number: 29491
Gerrit-PatchSet: 1
Gerrit-Owner: Li1 Feng <li1.feng at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181106/b3635d91/attachment-0001.html>


More information about the coreboot-gerrit mailing list