[coreboot-gerrit] Change in coreboot[master]: [RFC] lib/spd_bin: Redesign API

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29481 )

Change subject: [RFC] lib/spd_bin: Redesign API
......................................................................


Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/29481/2/src/include/spd_bin.h
File src/include/spd_bin.h:

https://review.coreboot.org/#/c/29481/2/src/include/spd_bin.h@92
PS2, Line 92: ssize_t gather_spds(struct spd_binfo *);
function definition argument 'struct spd_binfo *' should also have an identifier name


https://review.coreboot.org/#/c/29481/2/src/include/spd_bin.h@94
PS2, Line 94: void dump_spd_info(const struct spd_binfo *);
function definition argument 'const struct spd_binfo *' should also have an identifier name


https://review.coreboot.org/#/c/29481/2/src/lib/spd_bin.c
File src/lib/spd_bin.c:

https://review.coreboot.org/#/c/29481/2/src/lib/spd_bin.c@227
PS2, Line 227: 			if (common_len == -1) {
braces {} are not necessary for any arm of this statement



-- 
To view, visit https://review.coreboot.org/29481
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac300a374e5cd56a9d202cf24ad8fe8367b780d8
Gerrit-Change-Number: 29481
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 05 Nov 2018 17:39:20 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181105/8bf85721/attachment.html>