[coreboot-gerrit] Change in coreboot[master]: device/i2c_bus: Add i2c_dev_readb_at_word()

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29478 )

Change subject: device/i2c_bus: Add i2c_dev_readb_at_word()
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/29478/1/src/device/i2c_bus.c
File src/device/i2c_bus.c:

https://review.coreboot.org/#/c/29478/1/src/device/i2c_bus.c@189
PS1, Line 189: 			transfer(busdev, msg, ARRAY_SIZE(msg));
Avoid multiple line dereference - prefer 'busdev->ops->ops_i2c_bus->transfer'


https://review.coreboot.org/#/c/29478/1/src/include/device/i2c_bus.h
File src/include/device/i2c_bus.h:

https://review.coreboot.org/#/c/29478/1/src/include/device/i2c_bus.h@98
PS1, Line 98: int i2c_dev_readb_at_word(struct device *,
function definition argument 'struct device *' should also have an identifier name



-- 
To view, visit https://review.coreboot.org/29478
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7516f3e5d9aca362c2b340aa5627d91510c09412
Gerrit-Change-Number: 29478
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 05 Nov 2018 17:36:51 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181105/e5a93461/attachment.html>