<p><a href="https://review.coreboot.org/29478">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29478/1/src/device/i2c_bus.c">File src/device/i2c_bus.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29478/1/src/device/i2c_bus.c@189">Patch Set #1, Line 189:</a> <code style="font-family:monospace,monospace">                   transfer(busdev, msg, ARRAY_SIZE(msg));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Avoid multiple line dereference - prefer 'busdev->ops->ops_i2c_bus->transfer'</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29478/1/src/include/device/i2c_bus.h">File src/include/device/i2c_bus.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29478/1/src/include/device/i2c_bus.h@98">Patch Set #1, Line 98:</a> <code style="font-family:monospace,monospace">int i2c_dev_readb_at_word(struct device *,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'struct device *' should also have an identifier name</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/29478">change 29478</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29478"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I7516f3e5d9aca362c2b340aa5627d91510c09412 </div>
<div style="display:none"> Gerrit-Change-Number: 29478 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 05 Nov 2018 17:36:51 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>