[coreboot-gerrit] Change in coreboot[master]: mb/google/kahlee: edp panel initialization time tuning

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Mon Nov 5 13:01:56 CET 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29469 )

Change subject: mb/google/kahlee: edp panel initialization time tuning
......................................................................


Patch Set 1:

(4 comments)

https://review.coreboot.org/#/c/29469/1/src/mainboard/google/kahlee/OemCustomize.c
File src/mainboard/google/kahlee/OemCustomize.c:

https://review.coreboot.org/#/c/29469/1/src/mainboard/google/kahlee/OemCustomize.c@84
PS1, Line 84: 					" config, \n");
unnecessary whitespace before a quoted newline


https://review.coreboot.org/#/c/29469/1/src/mainboard/google/kahlee/OemCustomize.c@88
PS1, Line 88: 	if ((cfg->lvds_poseq_blon_to_varybl) && (cfg->lvds_poseq_varybl_to_blon)) {
line over 80 characters


https://review.coreboot.org/#/c/29469/1/src/mainboard/google/kahlee/OemCustomize.c@90
PS1, Line 90: 		params->LvdsPowerOnSeqVaryBlToBlon = cfg->lvds_poseq_varybl_to_blon;
line over 80 characters


https://review.coreboot.org/#/c/29469/1/src/mainboard/google/kahlee/OemCustomize.c@91
PS1, Line 91: 		params->LvdsPowerOnSeqBlonToVaryBl = cfg->lvds_poseq_blon_to_varybl;
line over 80 characters



-- 
To view, visit https://review.coreboot.org/29469
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib20c48813b208d697b950b2f02a70a690e483fdb
Gerrit-Change-Number: 29469
Gerrit-PatchSet: 1
Gerrit-Owner: chris wang <Chris.Wang at amd.com>
Gerrit-Reviewer: Chris Wang <chris.wang at amd.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 05 Nov 2018 12:01:56 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181105/113af902/attachment.html>


More information about the coreboot-gerrit mailing list