[coreboot-gerrit] Change in coreboot[master]: mb/lenovo/x220: Add x1 as a variant

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29434 )

Change subject: mb/lenovo/x220: Add x1 as a variant
......................................................................


Patch Set 5: Code-Review+1

(4 comments)

https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x1/devicetree.cb
File src/mainboard/lenovo/x220/variants/x1/devicetree.cb:

https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x1/devicetree.cb@71
PS5, Line 71: 0, 0, 0, 0, 0, 0, 0, 0
The Expresscard port should have a one here.


https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x1/devicetree.cb@79
PS5, Line 79: 0x2005
Does it have two flash chips ? It's not clear from the documentation.


https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x1/devicetree.cb@104
PS5, Line 104: on
What's behind those ports ? One might be for Expresscard.


https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x1/devicetree.cb@173
PS5, Line 173: has_bdc_detection
Does BDC detection properly work ?
Maybe it was fixed while updating the design.



-- 
To view, visit https://review.coreboot.org/29434
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1
Gerrit-Change-Number: 29434
Gerrit-PatchSet: 5
Gerrit-Owner: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 04 Nov 2018 07:22:06 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181104/27c466b7/attachment.html>