<p>Patch set 5:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://review.coreboot.org/29434">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x1/devicetree.cb">File src/mainboard/lenovo/x220/variants/x1/devicetree.cb:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x1/devicetree.cb@71">Patch Set #5, Line 71:</a> <code style="font-family:monospace,monospace">0, 0, 0, 0, 0, 0, 0, 0</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">The Expresscard port should have a one here.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x1/devicetree.cb@79">Patch Set #5, Line 79:</a> <code style="font-family:monospace,monospace">0x2005</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Does it have two flash chips ? It's not clear from the documentation.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x1/devicetree.cb@104">Patch Set #5, Line 104:</a> <code style="font-family:monospace,monospace">on</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">What's behind those ports ? One might be for Expresscard.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x1/devicetree.cb@173">Patch Set #5, Line 173:</a> <code style="font-family:monospace,monospace">has_bdc_detection</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Does BDC detection properly work ?<br>Maybe it was fixed while updating the design.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/29434">change 29434</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29434"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1 </div>
<div style="display:none"> Gerrit-Change-Number: 29434 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Bill XIE <persmule@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 04 Nov 2018 07:22:06 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>