[coreboot-gerrit] Change in coreboot[master]: src/soc/intel/braswell/southcluster.c: Correct configuration of inter...

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Thu Nov 1 13:54:35 CET 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29419 )

Change subject: src/soc/intel/braswell/southcluster.c: Correct configuration of interrupts
......................................................................


Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/29419/3/src/soc/intel/braswell/southcluster.c
File src/soc/intel/braswell/southcluster.c:

https://review.coreboot.org/#/c/29419/3/src/soc/intel/braswell/southcluster.c@167
PS3, Line 167: 			/* Set the Interrupt line register as "unknown or unused" */
line over 80 characters


https://review.coreboot.org/#/c/29419/3/src/soc/intel/braswell/southcluster.c@297
PS3, Line 297: 	} else
suspect code indent for conditional statements (8, 24)



-- 
To view, visit https://review.coreboot.org/29419
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I128cb35dd0e348a9cd9fb162651e0aa2b7e4a3ef
Gerrit-Change-Number: 29419
Gerrit-PatchSet: 3
Gerrit-Owner: Frans Hendriks <fhendriks at eltan.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 01 Nov 2018 12:54:35 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181101/348c4953/attachment.html>


More information about the coreboot-gerrit mailing list