[coreboot-gerrit] Change in coreboot[master]: src/soc/intel/braswell/southcluster.c: Correct configuration of inter...

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29419 )

Change subject: src/soc/intel/braswell/southcluster.c: Correct configuration of interrupts
......................................................................


Patch Set 1:

(12 comments)

https://review.coreboot.org/#/c/29419/1/src/soc/intel/braswell/southcluster.c
File src/soc/intel/braswell/southcluster.c:

https://review.coreboot.org/#/c/29419/1/src/soc/intel/braswell/southcluster.c@120
PS1, Line 120: 	for(irq_dev = all_devices; irq_dev; irq_dev = irq_dev->next) {
space required before the open parenthesis '('


https://review.coreboot.org/#/c/29419/1/src/soc/intel/braswell/southcluster.c@152
PS1, Line 152: 		/* Find the PIRQ that is attached to the INT_PIN this device uses */
line over 80 characters


https://review.coreboot.org/#/c/29419/1/src/soc/intel/braswell/southcluster.c@153
PS1, Line 153: 		pirq = (ir->pcidev[device_num] >> ((new_int_pin - 1) * 4)) & 0x7;
line over 80 characters


https://review.coreboot.org/#/c/29419/1/src/soc/intel/braswell/southcluster.c@159
PS1, Line 159: 			/* Set this IRQ to level triggered since it is used by a PCI device */
line over 80 characters


https://review.coreboot.org/#/c/29419/1/src/soc/intel/braswell/southcluster.c@160
PS1, Line 160: 			i8259_configure_irq_trigger(int_line, IRQ_LEVEL_TRIGGERED);
line over 80 characters


https://review.coreboot.org/#/c/29419/1/src/soc/intel/braswell/southcluster.c@161
PS1, Line 161: 			/* Set the Interrupt Line register in PCI config space */
line over 80 characters


https://review.coreboot.org/#/c/29419/1/src/soc/intel/braswell/southcluster.c@162
PS1, Line 162: 			pci_write_config8(irq_dev, PCI_INTERRUPT_LINE, int_line);
line over 80 characters


https://review.coreboot.org/#/c/29419/1/src/soc/intel/braswell/southcluster.c@164
PS1, Line 164: 			/* Set the Interrupt line register as "unknown or unused" */
line over 80 characters


https://review.coreboot.org/#/c/29419/1/src/soc/intel/braswell/southcluster.c@173
PS1, Line 173: 							new_int_pin, pin_to_str(new_int_pin));
line over 80 characters


https://review.coreboot.org/#/c/29419/1/src/soc/intel/braswell/southcluster.c@284
PS1, Line 284: 		if ( ir->pic[i] ) {
space prohibited after that open parenthesis '('


https://review.coreboot.org/#/c/29419/1/src/soc/intel/braswell/southcluster.c@284
PS1, Line 284: 		if ( ir->pic[i] ) {
space prohibited before that close parenthesis ')'


https://review.coreboot.org/#/c/29419/1/src/soc/intel/braswell/southcluster.c@284
PS1, Line 284: 		if ( ir->pic[i] ) {
braces {} are not necessary for single statement blocks



-- 
To view, visit https://review.coreboot.org/29419
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I128cb35dd0e348a9cd9fb162651e0aa2b7e4a3ef
Gerrit-Change-Number: 29419
Gerrit-PatchSet: 1
Gerrit-Owner: Frans Hendriks <fhendriks at eltan.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 01 Nov 2018 10:38:56 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181101/113d8ded/attachment.html>