[coreboot-gerrit] Change in coreboot[master]: mb/*/*: Update IOAPIC GPIO pad configuration to include trigger mode

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26731 )

Change subject: mb/*/*: Update IOAPIC GPIO pad configuration to include trigger mode
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/26731/1/src/mainboard/google/octopus/variants/baseboard/gpio.c
File src/mainboard/google/octopus/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/26731/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@196
PS1, Line 196: 	PAD_CFG_GPI_APIC_LOW(GPIO_135, NONE, DEEP, LEVEL),/* GPIO_135 -- TRACKPAD_INT1_1V8_ODL */
line over 80 characters


https://review.coreboot.org/#/c/26731/1/src/mainboard/google/octopus/variants/bip/gpio.c
File src/mainboard/google/octopus/variants/bip/gpio.c:

https://review.coreboot.org/#/c/26731/1/src/mainboard/google/octopus/variants/bip/gpio.c@194
PS1, Line 194: 	PAD_CFG_GPI_APIC_LOW(GPIO_135, NONE, DEEP, LEVEL),/* GPIO_135 -- TRACKPAD_INT1_1V8_ODL */
line over 80 characters



-- 
To view, visit https://review.coreboot.org/26731
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e1f009489f2d8338ae94b78d7e9eb3f88a85dab
Gerrit-Change-Number: 26731
Gerrit-PatchSet: 1
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 31 May 2018 10:26:18 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180531/8c973f2d/attachment.html>