[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nami: Add delay to enable_gpio during Elan p...

Shelley Chen (Code Review) gerrit at coreboot.org
Thu May 31 05:23:55 CEST 2018


Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/26725


Change subject: mb/google/poppy/variants/nami: Add delay to enable_gpio during Elan power on
......................................................................

mb/google/poppy/variants/nami: Add delay to enable_gpio during Elan power on

During measurement of signals during Elan touchscreen power on, saw
that the enable_gpio delay was not sufficient as there is a +1.5 ms
delay during power on.  Adding more delay to take this into account.

BUG=b:78311818
BRANCH=None
TEST=probe power on signals to ensure meet timing requirements

Change-Id: Id661a202188a97aef97514ebecd0be6fc022d21e
Signed-off-by: Shelley Chen <shchen at google.com>
---
M src/mainboard/google/poppy/variants/nami/devicetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/26725/1

diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb
index 5e2575f..9c4b694 100644
--- a/src/mainboard/google/poppy/variants/nami/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb
@@ -296,7 +296,7 @@
 				register "reset_delay_ms" = "20"
 				register "reset_off_delay_ms" = "2"
 				register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B4)"
-				register "enable_delay_ms" = "1"
+				register "enable_delay_ms" = "5"
 				register "enable_off_delay_ms" = "100"
 				register "has_power_resource" = "1"
 				register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C3)"

-- 
To view, visit https://review.coreboot.org/26725
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id661a202188a97aef97514ebecd0be6fc022d21e
Gerrit-Change-Number: 26725
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen <shchen at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180531/ec540ba4/attachment.html>


More information about the coreboot-gerrit mailing list