<p>Shelley Chen has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26725">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variants/nami: Add delay to enable_gpio during Elan power on<br><br>During measurement of signals during Elan touchscreen power on, saw<br>that the enable_gpio delay was not sufficient as there is a +1.5 ms<br>delay during power on.  Adding more delay to take this into account.<br><br>BUG=b:78311818<br>BRANCH=None<br>TEST=probe power on signals to ensure meet timing requirements<br><br>Change-Id: Id661a202188a97aef97514ebecd0be6fc022d21e<br>Signed-off-by: Shelley Chen <shchen@google.com><br>---<br>M src/mainboard/google/poppy/variants/nami/devicetree.cb<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/26725/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb</span><br><span>index 5e2575f..9c4b694 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nami/devicetree.cb</span><br><span>+++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb</span><br><span>@@ -296,7 +296,7 @@</span><br><span>                           register "reset_delay_ms" = "20"</span><br><span>                                 register "reset_off_delay_ms" = "2"</span><br><span>                              register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B4)"</span><br><span style="color: hsl(0, 100%, 40%);">-                             register "enable_delay_ms" = "1"</span><br><span style="color: hsl(120, 100%, 40%);">+                          register "enable_delay_ms" = "5"</span><br><span>                                 register "enable_off_delay_ms" = "100"</span><br><span>                           register "has_power_resource" = "1"</span><br><span>                              register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C3)"</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26725">change 26725</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26725"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id661a202188a97aef97514ebecd0be6fc022d21e </div>
<div style="display:none"> Gerrit-Change-Number: 26725 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Shelley Chen <shchen@google.com> </div>