[coreboot-gerrit] Change in coreboot[master]: mb/google/kahlee: Remove #include <soc/smi.h> from GPIO code and header

[Richard Spiegel (Code Review)]

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/26721


Change subject: mb/google/kahlee: Remove #include <soc/smi.h> from GPIO code and header
......................................................................

mb/google/kahlee: Remove #include <soc/smi.h> from GPIO code and header

Because of struct sci_source table of events that have to generate SCI or
SMI, #include <soc/smi.h> was added to kahlee/grunt gpio.c files. It was also
added to variants.h. However, new code transfered most of SCI/SMI/interrupt
programming (with exception of events not associated to a GPIO pin). Because
of this, soc/amd/stoneyridge/include/soc/gpio.h now have the header inclusion
"#include <soc/smi.h>", and files within motherboard related to GPIO don't
need it anymore. For some unknown reason, mainboard.c also has the smi.h
include and don't need it. Only smihandler.c truly needs it.
Remove the includes.

BUG=b:78139413
TEST=build and boot grunt.

Change-Id: I64cf0796103a5226ddace03d05d94160bf93aa69
Signed-off-by: Richard Spiegel <richard.spiegel at silverbackltd.com>
---
M src/mainboard/google/kahlee/mainboard.c
M src/mainboard/google/kahlee/variants/baseboard/gpio.c
M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h
M src/mainboard/google/kahlee/variants/kahlee/gpio.c
4 files changed, 0 insertions(+), 4 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/26721/1

diff --git a/src/mainboard/google/kahlee/mainboard.c b/src/mainboard/google/kahlee/mainboard.c
index e090401..6f7882f 100644
--- a/src/mainboard/google/kahlee/mainboard.c
+++ b/src/mainboard/google/kahlee/mainboard.c
@@ -26,7 +26,6 @@
 #include <smbios.h>
 #include <soc/nvs.h>
 #include <soc/pci_devs.h>
-#include <soc/smi.h>
 #include <soc/southbridge.h>
 #include <variant/ec.h>
 #include <variant/thermal.h>
diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c
index c7bd6a5..4a7cfae 100644
--- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c
+++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c
@@ -16,7 +16,6 @@
 #include <compiler.h>
 #include <baseboard/variants.h>
 #include <soc/gpio.h>
-#include <soc/smi.h>
 #include <soc/southbridge.h>
 #include <stdlib.h>
 #include <boardid.h>
diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h
index fc754b5..23f9cb0 100644
--- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h
+++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h
@@ -18,7 +18,6 @@
 #define __BASEBOARD_VARIANTS_H__
 
 #include <stddef.h>
-#include <soc/smi.h>
 #include <soc/southbridge.h>
 
 const struct sci_source *get_gpe_table(size_t *num);
diff --git a/src/mainboard/google/kahlee/variants/kahlee/gpio.c b/src/mainboard/google/kahlee/variants/kahlee/gpio.c
index 3072350..75354de 100644
--- a/src/mainboard/google/kahlee/variants/kahlee/gpio.c
+++ b/src/mainboard/google/kahlee/variants/kahlee/gpio.c
@@ -14,7 +14,6 @@
  */
 
 #include <baseboard/variants.h>
-#include <soc/smi.h>
 #include <soc/southbridge.h>
 #include <stdlib.h>
 #include <variant/gpio.h>

-- 
To view, visit https://review.coreboot.org/26721
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I64cf0796103a5226ddace03d05d94160bf93aa69
Gerrit-Change-Number: 26721
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180531/377f7d9a/attachment.html>