<p>Richard Spiegel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26721">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/kahlee: Remove #include <soc/smi.h> from GPIO code and header<br><br>Because of struct sci_source table of events that have to generate SCI or<br>SMI, #include <soc/smi.h> was added to kahlee/grunt gpio.c files. It was also<br>added to variants.h. However, new code transfered most of SCI/SMI/interrupt<br>programming (with exception of events not associated to a GPIO pin). Because<br>of this, soc/amd/stoneyridge/include/soc/gpio.h now have the header inclusion<br>"#include <soc/smi.h>", and files within motherboard related to GPIO don't<br>need it anymore. For some unknown reason, mainboard.c also has the smi.h<br>include and don't need it. Only smihandler.c truly needs it.<br>Remove the includes.<br><br>BUG=b:78139413<br>TEST=build and boot grunt.<br><br>Change-Id: I64cf0796103a5226ddace03d05d94160bf93aa69<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/mainboard/google/kahlee/mainboard.c<br>M src/mainboard/google/kahlee/variants/baseboard/gpio.c<br>M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h<br>M src/mainboard/google/kahlee/variants/kahlee/gpio.c<br>4 files changed, 0 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/26721/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/kahlee/mainboard.c b/src/mainboard/google/kahlee/mainboard.c</span><br><span>index e090401..6f7882f 100644</span><br><span>--- a/src/mainboard/google/kahlee/mainboard.c</span><br><span>+++ b/src/mainboard/google/kahlee/mainboard.c</span><br><span>@@ -26,7 +26,6 @@</span><br><span> #include <smbios.h></span><br><span> #include <soc/nvs.h></span><br><span> #include <soc/pci_devs.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <soc/smi.h></span><br><span> #include <soc/southbridge.h></span><br><span> #include <variant/ec.h></span><br><span> #include <variant/thermal.h></span><br><span>diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c</span><br><span>index c7bd6a5..4a7cfae 100644</span><br><span>--- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c</span><br><span>+++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c</span><br><span>@@ -16,7 +16,6 @@</span><br><span> #include <compiler.h></span><br><span> #include <baseboard/variants.h></span><br><span> #include <soc/gpio.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <soc/smi.h></span><br><span> #include <soc/southbridge.h></span><br><span> #include <stdlib.h></span><br><span> #include <boardid.h></span><br><span>diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h</span><br><span>index fc754b5..23f9cb0 100644</span><br><span>--- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h</span><br><span>+++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h</span><br><span>@@ -18,7 +18,6 @@</span><br><span> #define __BASEBOARD_VARIANTS_H__</span><br><span> </span><br><span> #include <stddef.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <soc/smi.h></span><br><span> #include <soc/southbridge.h></span><br><span> </span><br><span> const struct sci_source *get_gpe_table(size_t *num);</span><br><span>diff --git a/src/mainboard/google/kahlee/variants/kahlee/gpio.c b/src/mainboard/google/kahlee/variants/kahlee/gpio.c</span><br><span>index 3072350..75354de 100644</span><br><span>--- a/src/mainboard/google/kahlee/variants/kahlee/gpio.c</span><br><span>+++ b/src/mainboard/google/kahlee/variants/kahlee/gpio.c</span><br><span>@@ -14,7 +14,6 @@</span><br><span>  */</span><br><span> </span><br><span> #include <baseboard/variants.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <soc/smi.h></span><br><span> #include <soc/southbridge.h></span><br><span> #include <stdlib.h></span><br><span> #include <variant/gpio.h></span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26721">change 26721</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26721"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I64cf0796103a5226ddace03d05d94160bf93aa69 </div>
<div style="display:none"> Gerrit-Change-Number: 26721 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>