[coreboot-gerrit] Change in coreboot[master]: device/oprom/x86emu/prim_ops.c: Fix coding style

Wed May 30 13:08:12 CEST 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26353 )

Change subject: device/oprom/x86emu/prim_ops.c: Fix coding style
......................................................................

Patch Set 8:

(90 comments)

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c
File src/device/oprom/x86emu/prim_ops.c:

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@195
PS8, Line 195: 	if (set_carry) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@295
PS8, Line 295: 	if (ACCESS_FLAG(F_CF)) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@314
PS8, Line 314: 	if (ACCESS_FLAG(F_CF)) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@763
PS8, Line 763: 	if ((cnt = s % 9) != 0) {
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@784
PS8, Line 784: 		if (ACCESS_FLAG(F_CF)) { /* carry flag is set */
suspect code indent for conditional statements (16, 32)

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@810
PS8, Line 810: 	if ((cnt = s % 17) != 0) {
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@815
PS8, Line 815: 		if (ACCESS_FLAG(F_CF)) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@834
PS8, Line 834: 	if ((cnt = s % 33) != 0) {
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@881
PS8, Line 881: 	if ((cnt = s % 9) != 0) {
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@886
PS8, Line 886: 			/* note hackery here.  Access_flag(..) evaluates to either
line over 80 characters

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@945
PS8, Line 945: 	if ((cnt = s % 17) != 0) {
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@954
PS8, Line 954: 		if (ACCESS_FLAG(F_CF)) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@977
PS8, Line 977: 	if ((cnt = s % 33) != 0) {
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1024
PS8, Line 1024: 	if ((cnt = s % 8) != 0) {
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1057
PS8, Line 1057: 	if ((cnt = s % 16) != 0) {
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1082
PS8, Line 1082: 	if ((cnt = s % 32) != 0) {
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1122
PS8, Line 1122: 	if ((cnt = s % 8) != 0) { /* not a typo, do nada if cnt==0 */
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1153
PS8, Line 1153: 	if ((cnt = s % 16) != 0) {
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1176
PS8, Line 1176: 	if ((cnt = s % 32) != 0) {
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1217
PS8, Line 1217:                 } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1217
PS8, Line 1217:                 } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1253
PS8, Line 1253:                 } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1253
PS8, Line 1253:                 } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1286
PS8, Line 1286: 			CONDITIONAL_SET_FLAG((((res & 0x80000000) == 0x80000000) ^
line over 80 characters

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1288
PS8, Line 1288:                 } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1288
PS8, Line 1288:                 } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1321
PS8, Line 1321: 		if (cnt == 1) {
braces {} are not necessary for any arm of this statement

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1323
PS8, Line 1323:                 } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1323
PS8, Line 1323:                 } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1356
PS8, Line 1356: 		if (cnt == 1) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1358
PS8, Line 1358:                 } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1358
PS8, Line 1358:                 } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1358
PS8, Line 1358:                 } else {
space required after that close brace '}'

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1358
PS8, Line 1358:                 } else {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1390
PS8, Line 1390: 		if (cnt == 1) {
braces {} are not necessary for any arm of this statement

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1392
PS8, Line 1392:                 } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1392
PS8, Line 1392:                 } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1422
PS8, Line 1422: 		if (sf) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1460
PS8, Line 1460: 		if (sf) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1498
PS8, Line 1498: 		if (sf) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1541
PS8, Line 1541:                 } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1541
PS8, Line 1541:                 } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1574
PS8, Line 1574: 			CONDITIONAL_SET_FLAG((((res & 0x80000000) == 0x80000000) ^
line over 80 characters

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1576
PS8, Line 1576:                 } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1576
PS8, Line 1576:                 } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1609
PS8, Line 1609: 		if (cnt == 1) {
braces {} are not necessary for any arm of this statement

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1611
PS8, Line 1611:                 } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1611
PS8, Line 1611:                 } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1643
PS8, Line 1643: 		if (cnt == 1) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1645
PS8, Line 1645:                 } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1645
PS8, Line 1645:                 } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1645
PS8, Line 1645:                 } else {
space required after that close brace '}'

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1645
PS8, Line 1645:                 } else {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1668
PS8, Line 1668: 	if (ACCESS_FLAG(F_CF)) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1670
PS8, Line 1670:         } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1670
PS8, Line 1670:         } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1670
PS8, Line 1670:         } else {
space required after that close brace '}'

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1670
PS8, Line 1670:         } else {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1692
PS8, Line 1692: 	if (ACCESS_FLAG(F_CF)) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1694
PS8, Line 1694:         } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1694
PS8, Line 1694:         } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1694
PS8, Line 1694:         } else {
space required after that close brace '}'

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1694
PS8, Line 1694:         } else {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1716
PS8, Line 1716: 	if (ACCESS_FLAG(F_CF)) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1718
PS8, Line 1718:         } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1718
PS8, Line 1718:         } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1718
PS8, Line 1718:         } else {
space required after that close brace '}'

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1718
PS8, Line 1718:         } else {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1934
PS8, Line 1934: 	if ((d_sign = d & 0x80000000) != 0) {
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1934
PS8, Line 1934: 	if ((d_sign = d & 0x80000000) != 0) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1939
PS8, Line 1939: 	if ((s_sign = s & 0x80000000) != 0) {
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1939
PS8, Line 1939: 	if ((s_sign = s & 0x80000000) != 0) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2304
PS8, Line 2304:         } else if (size == 2) {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2304
PS8, Line 2304:         } else if (size == 2) {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2304
PS8, Line 2304:         } else if (size == 2) {
space required after that close brace '}'

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2307
PS8, Line 2307:         } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2307
PS8, Line 2307:         } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2307
PS8, Line 2307:         } else {
space required after that close brace '}'

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2317
PS8, Line 2317: 	if (ACCESS_FLAG(F_DF)) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2352
PS8, Line 2352:         } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2352
PS8, Line 2352:         } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2352
PS8, Line 2352:         } else {
space required after that close brace '}'

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2362
PS8, Line 2362: 	if (ACCESS_FLAG(F_DF)) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2375
PS8, Line 2375: 		if (M.x86.mode & SYSMODE_32BIT_REP) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2471
PS8, Line 2471: 		/* Regardless if we have real data from the hardware, the emulator
line over 80 characters

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2472
PS8, Line 2472: 		 * will only support upto feature 1, which we set in register EAX.
line over 80 characters

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2482
PS8, Line 2482: 		/* If we don't have x86 compatible hardware, we return values from an
line over 80 characters

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2483
PS8, Line 2483: 		 * Intel 486dx4; which was one of the first processors to have CPUID.
line over 80 characters

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2489
PS8, Line 2489: 		/* In the case that we have hardware CPUID instruction, we make sure
line over 80 characters

https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2496
PS8, Line 2496: 		 * return all zeros when queried for invalid or unsupported feature
line over 80 characters

-- 
To view, visit https://review.coreboot.org/26353
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I010f3e02813d38293a7ab7fc84f60b8c2ec098a7
Gerrit-Change-Number: 26353
Gerrit-PatchSet: 8
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Comment-Date: Wed, 30 May 2018 11:08:12 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180530/6505004c/attachment.html>