<p><a href="https://review.coreboot.org/26353">View Change</a></p><p>90 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c">File src/device/oprom/x86emu/prim_ops.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@195">Patch Set #8, Line 195:</a> <code style="font-family:monospace,monospace"> if (set_carry) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@295">Patch Set #8, Line 295:</a> <code style="font-family:monospace,monospace"> if (ACCESS_FLAG(F_CF)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@314">Patch Set #8, Line 314:</a> <code style="font-family:monospace,monospace"> if (ACCESS_FLAG(F_CF)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@763">Patch Set #8, Line 763:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 9) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@784">Patch Set #8, Line 784:</a> <code style="font-family:monospace,monospace"> if (ACCESS_FLAG(F_CF)) { /* carry flag is set */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">suspect code indent for conditional statements (16, 32)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@810">Patch Set #8, Line 810:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 17) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@815">Patch Set #8, Line 815:</a> <code style="font-family:monospace,monospace"> if (ACCESS_FLAG(F_CF)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@834">Patch Set #8, Line 834:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 33) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@881">Patch Set #8, Line 881:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 9) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@886">Patch Set #8, Line 886:</a> <code style="font-family:monospace,monospace"> /* note hackery here. Access_flag(..) evaluates to either</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@945">Patch Set #8, Line 945:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 17) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@954">Patch Set #8, Line 954:</a> <code style="font-family:monospace,monospace"> if (ACCESS_FLAG(F_CF)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@977">Patch Set #8, Line 977:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 33) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1024">Patch Set #8, Line 1024:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 8) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1057">Patch Set #8, Line 1057:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 16) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1082">Patch Set #8, Line 1082:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 32) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1122">Patch Set #8, Line 1122:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 8) != 0) { /* not a typo, do nada if cnt==0 */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1153">Patch Set #8, Line 1153:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 16) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1176">Patch Set #8, Line 1176:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 32) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1217">Patch Set #8, Line 1217:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1217">Patch Set #8, Line 1217:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1253">Patch Set #8, Line 1253:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1253">Patch Set #8, Line 1253:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1286">Patch Set #8, Line 1286:</a> <code style="font-family:monospace,monospace"> CONDITIONAL_SET_FLAG((((res & 0x80000000) == 0x80000000) ^</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1288">Patch Set #8, Line 1288:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1288">Patch Set #8, Line 1288:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1321">Patch Set #8, Line 1321:</a> <code style="font-family:monospace,monospace"> if (cnt == 1) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for any arm of this statement</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1323">Patch Set #8, Line 1323:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1323">Patch Set #8, Line 1323:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1356">Patch Set #8, Line 1356:</a> <code style="font-family:monospace,monospace"> if (cnt == 1) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1358">Patch Set #8, Line 1358:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1358">Patch Set #8, Line 1358:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1358">Patch Set #8, Line 1358:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that close brace '}'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1358">Patch Set #8, Line 1358:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1390">Patch Set #8, Line 1390:</a> <code style="font-family:monospace,monospace"> if (cnt == 1) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for any arm of this statement</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1392">Patch Set #8, Line 1392:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1392">Patch Set #8, Line 1392:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1422">Patch Set #8, Line 1422:</a> <code style="font-family:monospace,monospace"> if (sf) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1460">Patch Set #8, Line 1460:</a> <code style="font-family:monospace,monospace"> if (sf) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1498">Patch Set #8, Line 1498:</a> <code style="font-family:monospace,monospace"> if (sf) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1541">Patch Set #8, Line 1541:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1541">Patch Set #8, Line 1541:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1574">Patch Set #8, Line 1574:</a> <code style="font-family:monospace,monospace"> CONDITIONAL_SET_FLAG((((res & 0x80000000) == 0x80000000) ^</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1576">Patch Set #8, Line 1576:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1576">Patch Set #8, Line 1576:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1609">Patch Set #8, Line 1609:</a> <code style="font-family:monospace,monospace"> if (cnt == 1) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for any arm of this statement</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1611">Patch Set #8, Line 1611:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1611">Patch Set #8, Line 1611:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1643">Patch Set #8, Line 1643:</a> <code style="font-family:monospace,monospace"> if (cnt == 1) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1645">Patch Set #8, Line 1645:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1645">Patch Set #8, Line 1645:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1645">Patch Set #8, Line 1645:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that close brace '}'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1645">Patch Set #8, Line 1645:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1668">Patch Set #8, Line 1668:</a> <code style="font-family:monospace,monospace"> if (ACCESS_FLAG(F_CF)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1670">Patch Set #8, Line 1670:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1670">Patch Set #8, Line 1670:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1670">Patch Set #8, Line 1670:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that close brace '}'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1670">Patch Set #8, Line 1670:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1692">Patch Set #8, Line 1692:</a> <code style="font-family:monospace,monospace"> if (ACCESS_FLAG(F_CF)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1694">Patch Set #8, Line 1694:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1694">Patch Set #8, Line 1694:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1694">Patch Set #8, Line 1694:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that close brace '}'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1694">Patch Set #8, Line 1694:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1716">Patch Set #8, Line 1716:</a> <code style="font-family:monospace,monospace"> if (ACCESS_FLAG(F_CF)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1718">Patch Set #8, Line 1718:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1718">Patch Set #8, Line 1718:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1718">Patch Set #8, Line 1718:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that close brace '}'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1718">Patch Set #8, Line 1718:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1934">Patch Set #8, Line 1934:</a> <code style="font-family:monospace,monospace"> if ((d_sign = d & 0x80000000) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1934">Patch Set #8, Line 1934:</a> <code style="font-family:monospace,monospace"> if ((d_sign = d & 0x80000000) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1939">Patch Set #8, Line 1939:</a> <code style="font-family:monospace,monospace"> if ((s_sign = s & 0x80000000) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@1939">Patch Set #8, Line 1939:</a> <code style="font-family:monospace,monospace"> if ((s_sign = s & 0x80000000) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2304">Patch Set #8, Line 2304:</a> <code style="font-family:monospace,monospace"> } else if (size == 2) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2304">Patch Set #8, Line 2304:</a> <code style="font-family:monospace,monospace"> } else if (size == 2) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2304">Patch Set #8, Line 2304:</a> <code style="font-family:monospace,monospace"> } else if (size == 2) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that close brace '}'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2307">Patch Set #8, Line 2307:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2307">Patch Set #8, Line 2307:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2307">Patch Set #8, Line 2307:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that close brace '}'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2317">Patch Set #8, Line 2317:</a> <code style="font-family:monospace,monospace"> if (ACCESS_FLAG(F_DF)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2352">Patch Set #8, Line 2352:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2352">Patch Set #8, Line 2352:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2352">Patch Set #8, Line 2352:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that close brace '}'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2362">Patch Set #8, Line 2362:</a> <code style="font-family:monospace,monospace"> if (ACCESS_FLAG(F_DF)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2375">Patch Set #8, Line 2375:</a> <code style="font-family:monospace,monospace"> if (M.x86.mode & SYSMODE_32BIT_REP) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2471">Patch Set #8, Line 2471:</a> <code style="font-family:monospace,monospace"> /* Regardless if we have real data from the hardware, the emulator</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2472">Patch Set #8, Line 2472:</a> <code style="font-family:monospace,monospace"> * will only support upto feature 1, which we set in register EAX.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2482">Patch Set #8, Line 2482:</a> <code style="font-family:monospace,monospace"> /* If we don't have x86 compatible hardware, we return values from an</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2483">Patch Set #8, Line 2483:</a> <code style="font-family:monospace,monospace"> * Intel 486dx4; which was one of the first processors to have CPUID.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2489">Patch Set #8, Line 2489:</a> <code style="font-family:monospace,monospace"> /* In the case that we have hardware CPUID instruction, we make sure</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/8/src/device/oprom/x86emu/prim_ops.c@2496">Patch Set #8, Line 2496:</a> <code style="font-family:monospace,monospace"> * return all zeros when queried for invalid or unsupported feature</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/26353">change 26353</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26353"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I010f3e02813d38293a7ab7fc84f60b8c2ec098a7 </div>
<div style="display:none"> Gerrit-Change-Number: 26353 </div>
<div style="display:none"> Gerrit-PatchSet: 8 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Werner Zeh <werner.zeh@siemens.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 30 May 2018 11:08:12 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>