[coreboot-gerrit] Change in coreboot[master]: device/oprom/x86emu/prim_ops.c: Fix coding style

Wed May 30 13:01:31 CEST 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26353 )

Change subject: device/oprom/x86emu/prim_ops.c: Fix coding style
......................................................................

Patch Set 7:

(83 comments)

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c
File src/device/oprom/x86emu/prim_ops.c:

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@760
PS7, Line 760: 	if ((cnt = s % 9) != 0) {
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@781
PS7, Line 781: 		if (ACCESS_FLAG(F_CF)) { /* carry flag is set */
suspect code indent for conditional statements (16, 32)

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@807
PS7, Line 807: 	if ((cnt = s % 17) != 0) {
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@812
PS7, Line 812: 		if (ACCESS_FLAG(F_CF)) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@831
PS7, Line 831: 	if ((cnt = s % 33) != 0) {
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@878
PS7, Line 878: 	if ((cnt = s % 9) != 0) {
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@883
PS7, Line 883: 			/* note hackery here.  Access_flag(..) evaluates to either
line over 80 characters

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@942
PS7, Line 942: 	if ((cnt = s % 17) != 0) {
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@951
PS7, Line 951: 		if (ACCESS_FLAG(F_CF)) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@974
PS7, Line 974: 	if ((cnt = s % 33) != 0) {
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1021
PS7, Line 1021: 	if ((cnt = s % 8) != 0) {
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1054
PS7, Line 1054: 	if ((cnt = s % 16) != 0) {
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1079
PS7, Line 1079: 	if ((cnt = s % 32) != 0) {
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1119
PS7, Line 1119: 	if ((cnt = s % 8) != 0) { /* not a typo, do nada if cnt==0 */
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1150
PS7, Line 1150: 	if ((cnt = s % 16) != 0) {
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1173
PS7, Line 1173: 	if ((cnt = s % 32) != 0) {
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1214
PS7, Line 1214:                 } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1214
PS7, Line 1214:                 } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1250
PS7, Line 1250:                 } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1250
PS7, Line 1250:                 } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1283
PS7, Line 1283: 			CONDITIONAL_SET_FLAG((((res & 0x80000000) == 0x80000000) ^
line over 80 characters

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1285
PS7, Line 1285:                 } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1285
PS7, Line 1285:                 } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1318
PS7, Line 1318: 		if (cnt == 1) {
braces {} are not necessary for any arm of this statement

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1320
PS7, Line 1320:                 } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1320
PS7, Line 1320:                 } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1353
PS7, Line 1353: 		if (cnt == 1) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1355
PS7, Line 1355:                 } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1355
PS7, Line 1355:                 } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1355
PS7, Line 1355:                 } else {
space required after that close brace '}'

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1355
PS7, Line 1355:                 } else {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1387
PS7, Line 1387: 		if (cnt == 1) {
braces {} are not necessary for any arm of this statement

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1389
PS7, Line 1389:                 } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1389
PS7, Line 1389:                 } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1419
PS7, Line 1419: 		if (sf) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1536
PS7, Line 1536:                 } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1536
PS7, Line 1536:                 } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1569
PS7, Line 1569: 			CONDITIONAL_SET_FLAG((((res & 0x80000000) == 0x80000000) ^
line over 80 characters

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1571
PS7, Line 1571:                 } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1571
PS7, Line 1571:                 } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1604
PS7, Line 1604: 		if (cnt == 1) {
braces {} are not necessary for any arm of this statement

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1606
PS7, Line 1606:                 } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1606
PS7, Line 1606:                 } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1638
PS7, Line 1638: 		if (cnt == 1) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1640
PS7, Line 1640:                 } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1640
PS7, Line 1640:                 } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1640
PS7, Line 1640:                 } else {
space required after that close brace '}'

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1640
PS7, Line 1640:                 } else {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1663
PS7, Line 1663: 	if (ACCESS_FLAG(F_CF)) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1665
PS7, Line 1665:         } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1665
PS7, Line 1665:         } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1665
PS7, Line 1665:         } else {
space required after that close brace '}'

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1665
PS7, Line 1665:         } else {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1687
PS7, Line 1687: 	if (ACCESS_FLAG(F_CF)) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1689
PS7, Line 1689:         } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1689
PS7, Line 1689:         } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1689
PS7, Line 1689:         } else {
space required after that close brace '}'

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1689
PS7, Line 1689:         } else {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1711
PS7, Line 1711: 	if (ACCESS_FLAG(F_CF)) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1713
PS7, Line 1713:         } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1713
PS7, Line 1713:         } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1713
PS7, Line 1713:         } else {
space required after that close brace '}'

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1713
PS7, Line 1713:         } else {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1929
PS7, Line 1929: 	if ((d_sign = d & 0x80000000) != 0)
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1933
PS7, Line 1933: 	if ((s_sign = s & 0x80000000) != 0)
do not use assignment in if condition

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2297
PS7, Line 2297:         } else if (size == 2) {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2297
PS7, Line 2297:         } else if (size == 2) {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2297
PS7, Line 2297:         } else if (size == 2) {
space required after that close brace '}'

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2300
PS7, Line 2300:         } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2300
PS7, Line 2300:         } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2300
PS7, Line 2300:         } else {
space required after that close brace '}'

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2310
PS7, Line 2310: 	if (ACCESS_FLAG(F_DF)) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2345
PS7, Line 2345:         } else {
code indent should use tabs where possible

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2345
PS7, Line 2345:         } else {
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2345
PS7, Line 2345:         } else {
space required after that close brace '}'

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2355
PS7, Line 2355: 	if (ACCESS_FLAG(F_DF)) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2368
PS7, Line 2368: 		if (M.x86.mode & SYSMODE_32BIT_REP) {
braces {} are not necessary for single statement blocks

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2464
PS7, Line 2464: 		/* Regardless if we have real data from the hardware, the emulator
line over 80 characters

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2465
PS7, Line 2465: 		 * will only support upto feature 1, which we set in register EAX.
line over 80 characters

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2475
PS7, Line 2475: 		/* If we don't have x86 compatible hardware, we return values from an
line over 80 characters

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2476
PS7, Line 2476: 		 * Intel 486dx4; which was one of the first processors to have CPUID.
line over 80 characters

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2482
PS7, Line 2482: 		/* In the case that we have hardware CPUID instruction, we make sure
line over 80 characters

https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2489
PS7, Line 2489: 		 * return all zeros when queried for invalid or unsupported feature
line over 80 characters

-- 
To view, visit https://review.coreboot.org/26353
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I010f3e02813d38293a7ab7fc84f60b8c2ec098a7
Gerrit-Change-Number: 26353
Gerrit-PatchSet: 7
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Comment-Date: Wed, 30 May 2018 11:01:31 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180530/8f223994/attachment.html>