<p><a href="https://review.coreboot.org/26353">View Change</a></p><p>83 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c">File src/device/oprom/x86emu/prim_ops.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@760">Patch Set #7, Line 760:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 9) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@781">Patch Set #7, Line 781:</a> <code style="font-family:monospace,monospace"> if (ACCESS_FLAG(F_CF)) { /* carry flag is set */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">suspect code indent for conditional statements (16, 32)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@807">Patch Set #7, Line 807:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 17) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@812">Patch Set #7, Line 812:</a> <code style="font-family:monospace,monospace"> if (ACCESS_FLAG(F_CF)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@831">Patch Set #7, Line 831:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 33) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@878">Patch Set #7, Line 878:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 9) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@883">Patch Set #7, Line 883:</a> <code style="font-family:monospace,monospace"> /* note hackery here. Access_flag(..) evaluates to either</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@942">Patch Set #7, Line 942:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 17) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@951">Patch Set #7, Line 951:</a> <code style="font-family:monospace,monospace"> if (ACCESS_FLAG(F_CF)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@974">Patch Set #7, Line 974:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 33) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1021">Patch Set #7, Line 1021:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 8) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1054">Patch Set #7, Line 1054:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 16) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1079">Patch Set #7, Line 1079:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 32) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1119">Patch Set #7, Line 1119:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 8) != 0) { /* not a typo, do nada if cnt==0 */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1150">Patch Set #7, Line 1150:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 16) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1173">Patch Set #7, Line 1173:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 32) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1214">Patch Set #7, Line 1214:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1214">Patch Set #7, Line 1214:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1250">Patch Set #7, Line 1250:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1250">Patch Set #7, Line 1250:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1283">Patch Set #7, Line 1283:</a> <code style="font-family:monospace,monospace"> CONDITIONAL_SET_FLAG((((res & 0x80000000) == 0x80000000) ^</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1285">Patch Set #7, Line 1285:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1285">Patch Set #7, Line 1285:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1318">Patch Set #7, Line 1318:</a> <code style="font-family:monospace,monospace"> if (cnt == 1) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for any arm of this statement</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1320">Patch Set #7, Line 1320:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1320">Patch Set #7, Line 1320:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1353">Patch Set #7, Line 1353:</a> <code style="font-family:monospace,monospace"> if (cnt == 1) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1355">Patch Set #7, Line 1355:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1355">Patch Set #7, Line 1355:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1355">Patch Set #7, Line 1355:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that close brace '}'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1355">Patch Set #7, Line 1355:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1387">Patch Set #7, Line 1387:</a> <code style="font-family:monospace,monospace"> if (cnt == 1) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for any arm of this statement</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1389">Patch Set #7, Line 1389:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1389">Patch Set #7, Line 1389:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1419">Patch Set #7, Line 1419:</a> <code style="font-family:monospace,monospace"> if (sf) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1536">Patch Set #7, Line 1536:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1536">Patch Set #7, Line 1536:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1569">Patch Set #7, Line 1569:</a> <code style="font-family:monospace,monospace"> CONDITIONAL_SET_FLAG((((res & 0x80000000) == 0x80000000) ^</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1571">Patch Set #7, Line 1571:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1571">Patch Set #7, Line 1571:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1604">Patch Set #7, Line 1604:</a> <code style="font-family:monospace,monospace"> if (cnt == 1) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for any arm of this statement</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1606">Patch Set #7, Line 1606:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1606">Patch Set #7, Line 1606:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1638">Patch Set #7, Line 1638:</a> <code style="font-family:monospace,monospace"> if (cnt == 1) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1640">Patch Set #7, Line 1640:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1640">Patch Set #7, Line 1640:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1640">Patch Set #7, Line 1640:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that close brace '}'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1640">Patch Set #7, Line 1640:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1663">Patch Set #7, Line 1663:</a> <code style="font-family:monospace,monospace"> if (ACCESS_FLAG(F_CF)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1665">Patch Set #7, Line 1665:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1665">Patch Set #7, Line 1665:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1665">Patch Set #7, Line 1665:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that close brace '}'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1665">Patch Set #7, Line 1665:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1687">Patch Set #7, Line 1687:</a> <code style="font-family:monospace,monospace"> if (ACCESS_FLAG(F_CF)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1689">Patch Set #7, Line 1689:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1689">Patch Set #7, Line 1689:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1689">Patch Set #7, Line 1689:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that close brace '}'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1689">Patch Set #7, Line 1689:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1711">Patch Set #7, Line 1711:</a> <code style="font-family:monospace,monospace"> if (ACCESS_FLAG(F_CF)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1713">Patch Set #7, Line 1713:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1713">Patch Set #7, Line 1713:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1713">Patch Set #7, Line 1713:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that close brace '}'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1713">Patch Set #7, Line 1713:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1929">Patch Set #7, Line 1929:</a> <code style="font-family:monospace,monospace"> if ((d_sign = d & 0x80000000) != 0)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1933">Patch Set #7, Line 1933:</a> <code style="font-family:monospace,monospace"> if ((s_sign = s & 0x80000000) != 0)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2297">Patch Set #7, Line 2297:</a> <code style="font-family:monospace,monospace"> } else if (size == 2) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2297">Patch Set #7, Line 2297:</a> <code style="font-family:monospace,monospace"> } else if (size == 2) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2297">Patch Set #7, Line 2297:</a> <code style="font-family:monospace,monospace"> } else if (size == 2) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that close brace '}'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2300">Patch Set #7, Line 2300:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2300">Patch Set #7, Line 2300:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2300">Patch Set #7, Line 2300:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that close brace '}'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2310">Patch Set #7, Line 2310:</a> <code style="font-family:monospace,monospace"> if (ACCESS_FLAG(F_DF)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2345">Patch Set #7, Line 2345:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2345">Patch Set #7, Line 2345:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2345">Patch Set #7, Line 2345:</a> <code style="font-family:monospace,monospace"> } else {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that close brace '}'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2355">Patch Set #7, Line 2355:</a> <code style="font-family:monospace,monospace"> if (ACCESS_FLAG(F_DF)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2368">Patch Set #7, Line 2368:</a> <code style="font-family:monospace,monospace"> if (M.x86.mode & SYSMODE_32BIT_REP) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2464">Patch Set #7, Line 2464:</a> <code style="font-family:monospace,monospace"> /* Regardless if we have real data from the hardware, the emulator</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2465">Patch Set #7, Line 2465:</a> <code style="font-family:monospace,monospace"> * will only support upto feature 1, which we set in register EAX.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2475">Patch Set #7, Line 2475:</a> <code style="font-family:monospace,monospace"> /* If we don't have x86 compatible hardware, we return values from an</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2476">Patch Set #7, Line 2476:</a> <code style="font-family:monospace,monospace"> * Intel 486dx4; which was one of the first processors to have CPUID.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2482">Patch Set #7, Line 2482:</a> <code style="font-family:monospace,monospace"> /* In the case that we have hardware CPUID instruction, we make sure</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2489">Patch Set #7, Line 2489:</a> <code style="font-family:monospace,monospace"> * return all zeros when queried for invalid or unsupported feature</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/26353">change 26353</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26353"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I010f3e02813d38293a7ab7fc84f60b8c2ec098a7 </div>
<div style="display:none"> Gerrit-Change-Number: 26353 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Werner Zeh <werner.zeh@siemens.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 30 May 2018 11:01:31 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>