[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Get rid of device_t

Elyes HAOUAS (Code Review) gerrit at coreboot.org
Sun May 27 16:58:24 CEST 2018


Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26584


Change subject: soc/intel/cannonlake: Get rid of device_t
......................................................................

soc/intel/cannonlake: Get rid of device_t

Use of device_t has been abandoned in ramstage.

Change-Id: Iea56a6560bb23d48d19211304e57fc08e1c27fd6
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/soc/intel/cannonlake/acpi.c
M src/soc/intel/cannonlake/chip.c
M src/soc/intel/cannonlake/cpu.c
M src/soc/intel/cannonlake/finalize.c
M src/soc/intel/cannonlake/pmc.c
M src/soc/intel/cannonlake/smmrelocate.c
6 files changed, 10 insertions(+), 10 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/26584/1

diff --git a/src/soc/intel/cannonlake/acpi.c b/src/soc/intel/cannonlake/acpi.c
index 0134b86..97d5ce7 100644
--- a/src/soc/intel/cannonlake/acpi.c
+++ b/src/soc/intel/cannonlake/acpi.c
@@ -142,7 +142,7 @@
 				ARRAY_SIZE(cstate_set_non_s0ix))];
 	int *set;
 	int i;
-	device_t dev = SA_DEV_ROOT;
+	struct device *dev = SA_DEV_ROOT;
 	config_t *config = dev->chip_info;
 	int is_s0ix_enable = config->s0ix_enable;
 
@@ -163,7 +163,7 @@
 
 void soc_power_states_generation(int core_id, int cores_per_package)
 {
-	device_t dev = SA_DEV_ROOT;
+	struct device *dev = SA_DEV_ROOT;
 	config_t *config = dev->chip_info;
 	if (config->eist_enable)
 		/* Generate P-state tables */
diff --git a/src/soc/intel/cannonlake/chip.c b/src/soc/intel/cannonlake/chip.c
index fd9ce52..0c4232c 100644
--- a/src/soc/intel/cannonlake/chip.c
+++ b/src/soc/intel/cannonlake/chip.c
@@ -140,7 +140,7 @@
 	fsp_display_fvi_version_hob();
 }
 
-static void pci_domain_set_resources(device_t dev)
+static void pci_domain_set_resources(struct device *dev)
 {
 	assign_resources(dev->link_list);
 }
@@ -162,7 +162,7 @@
 	.acpi_fill_ssdt_generator = generate_cpu_entries,
 };
 
-static void soc_enable(device_t dev)
+static void soc_enable(struct device *dev)
 {
 	/* Set the operations if it is a special bus type */
 	if (dev->path.type == DEVICE_PATH_DOMAIN)
diff --git a/src/soc/intel/cannonlake/cpu.c b/src/soc/intel/cannonlake/cpu.c
index a0797bc..dc413e2 100644
--- a/src/soc/intel/cannonlake/cpu.c
+++ b/src/soc/intel/cannonlake/cpu.c
@@ -36,7 +36,7 @@
 
 static void configure_isst(void)
 {
-	device_t dev = SA_DEV_ROOT;
+	struct device *dev = SA_DEV_ROOT;
 	config_t *conf = dev->chip_info;
 	msr_t msr;
 
@@ -62,7 +62,7 @@
 
 static void configure_misc(void)
 {
-	device_t dev = SA_DEV_ROOT;
+	struct device *dev = SA_DEV_ROOT;
 	config_t *conf = dev->chip_info;
 	msr_t msr;
 
@@ -166,7 +166,7 @@
 }
 
 /* All CPUs including BSP will run the following function. */
-void soc_core_init(device_t cpu)
+void soc_core_init(struct device *cpu)
 {
 	/* Clear out pending MCEs */
 	/* TODO(adurbin): This should only be done on a cold boot. Also, some
diff --git a/src/soc/intel/cannonlake/finalize.c b/src/soc/intel/cannonlake/finalize.c
index 5216460..b3c07b1 100644
--- a/src/soc/intel/cannonlake/finalize.c
+++ b/src/soc/intel/cannonlake/finalize.c
@@ -53,7 +53,7 @@
 
 static void pch_finalize(void)
 {
-	device_t dev;
+	struct device *dev;
 	uint32_t reg32;
 	uint16_t tcobase, tcocnt;
 	uint8_t *pmcbase;
diff --git a/src/soc/intel/cannonlake/pmc.c b/src/soc/intel/cannonlake/pmc.c
index c6c1694..ecd47e0 100644
--- a/src/soc/intel/cannonlake/pmc.c
+++ b/src/soc/intel/cannonlake/pmc.c
@@ -137,7 +137,7 @@
 
 static void pmc_init(void *unused)
 {
-	device_t dev = PCH_DEV_PMC;
+	struct device *dev = PCH_DEV_PMC;
 	config_t *config = dev->chip_info;
 
 	rtc_init();
diff --git a/src/soc/intel/cannonlake/smmrelocate.c b/src/soc/intel/cannonlake/smmrelocate.c
index 20da625..83330e6 100644
--- a/src/soc/intel/cannonlake/smmrelocate.c
+++ b/src/soc/intel/cannonlake/smmrelocate.c
@@ -170,7 +170,7 @@
 		write_smrr(relo_params);
 }
 
-static void fill_in_relocation_params(device_t dev,
+static void fill_in_relocation_params(struct device *dev,
 				      struct smm_relocation_params *params)
 {
 	void *handler_base;

-- 
To view, visit https://review.coreboot.org/26584
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea56a6560bb23d48d19211304e57fc08e1c27fd6
Gerrit-Change-Number: 26584
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180527/f76a4bbd/attachment.html>


More information about the coreboot-gerrit mailing list