<p>Elyes HAOUAS has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26584">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/cannonlake: Get rid of device_t<br><br>Use of device_t has been abandoned in ramstage.<br><br>Change-Id: Iea56a6560bb23d48d19211304e57fc08e1c27fd6<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/soc/intel/cannonlake/acpi.c<br>M src/soc/intel/cannonlake/chip.c<br>M src/soc/intel/cannonlake/cpu.c<br>M src/soc/intel/cannonlake/finalize.c<br>M src/soc/intel/cannonlake/pmc.c<br>M src/soc/intel/cannonlake/smmrelocate.c<br>6 files changed, 10 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/26584/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/cannonlake/acpi.c b/src/soc/intel/cannonlake/acpi.c</span><br><span>index 0134b86..97d5ce7 100644</span><br><span>--- a/src/soc/intel/cannonlake/acpi.c</span><br><span>+++ b/src/soc/intel/cannonlake/acpi.c</span><br><span>@@ -142,7 +142,7 @@</span><br><span> ARRAY_SIZE(cstate_set_non_s0ix))];</span><br><span> int *set;</span><br><span> int i;</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev = SA_DEV_ROOT;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev = SA_DEV_ROOT;</span><br><span> config_t *config = dev->chip_info;</span><br><span> int is_s0ix_enable = config->s0ix_enable;</span><br><span> </span><br><span>@@ -163,7 +163,7 @@</span><br><span> </span><br><span> void soc_power_states_generation(int core_id, int cores_per_package)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev = SA_DEV_ROOT;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev = SA_DEV_ROOT;</span><br><span> config_t *config = dev->chip_info;</span><br><span> if (config->eist_enable)</span><br><span> /* Generate P-state tables */</span><br><span>diff --git a/src/soc/intel/cannonlake/chip.c b/src/soc/intel/cannonlake/chip.c</span><br><span>index fd9ce52..0c4232c 100644</span><br><span>--- a/src/soc/intel/cannonlake/chip.c</span><br><span>+++ b/src/soc/intel/cannonlake/chip.c</span><br><span>@@ -140,7 +140,7 @@</span><br><span> fsp_display_fvi_version_hob();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void pci_domain_set_resources(device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+static void pci_domain_set_resources(struct device *dev)</span><br><span> {</span><br><span> assign_resources(dev->link_list);</span><br><span> }</span><br><span>@@ -162,7 +162,7 @@</span><br><span> .acpi_fill_ssdt_generator = generate_cpu_entries,</span><br><span> };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void soc_enable(device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+static void soc_enable(struct device *dev)</span><br><span> {</span><br><span> /* Set the operations if it is a special bus type */</span><br><span> if (dev->path.type == DEVICE_PATH_DOMAIN)</span><br><span>diff --git a/src/soc/intel/cannonlake/cpu.c b/src/soc/intel/cannonlake/cpu.c</span><br><span>index a0797bc..dc413e2 100644</span><br><span>--- a/src/soc/intel/cannonlake/cpu.c</span><br><span>+++ b/src/soc/intel/cannonlake/cpu.c</span><br><span>@@ -36,7 +36,7 @@</span><br><span> </span><br><span> static void configure_isst(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev = SA_DEV_ROOT;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev = SA_DEV_ROOT;</span><br><span> config_t *conf = dev->chip_info;</span><br><span> msr_t msr;</span><br><span> </span><br><span>@@ -62,7 +62,7 @@</span><br><span> </span><br><span> static void configure_misc(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev = SA_DEV_ROOT;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev = SA_DEV_ROOT;</span><br><span> config_t *conf = dev->chip_info;</span><br><span> msr_t msr;</span><br><span> </span><br><span>@@ -166,7 +166,7 @@</span><br><span> }</span><br><span> </span><br><span> /* All CPUs including BSP will run the following function. */</span><br><span style="color: hsl(0, 100%, 40%);">-void soc_core_init(device_t cpu)</span><br><span style="color: hsl(120, 100%, 40%);">+void soc_core_init(struct device *cpu)</span><br><span> {</span><br><span> /* Clear out pending MCEs */</span><br><span> /* TODO(adurbin): This should only be done on a cold boot. Also, some</span><br><span>diff --git a/src/soc/intel/cannonlake/finalize.c b/src/soc/intel/cannonlake/finalize.c</span><br><span>index 5216460..b3c07b1 100644</span><br><span>--- a/src/soc/intel/cannonlake/finalize.c</span><br><span>+++ b/src/soc/intel/cannonlake/finalize.c</span><br><span>@@ -53,7 +53,7 @@</span><br><span> </span><br><span> static void pch_finalize(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev;</span><br><span> uint32_t reg32;</span><br><span> uint16_t tcobase, tcocnt;</span><br><span> uint8_t *pmcbase;</span><br><span>diff --git a/src/soc/intel/cannonlake/pmc.c b/src/soc/intel/cannonlake/pmc.c</span><br><span>index c6c1694..ecd47e0 100644</span><br><span>--- a/src/soc/intel/cannonlake/pmc.c</span><br><span>+++ b/src/soc/intel/cannonlake/pmc.c</span><br><span>@@ -137,7 +137,7 @@</span><br><span> </span><br><span> static void pmc_init(void *unused)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev = PCH_DEV_PMC;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev = PCH_DEV_PMC;</span><br><span> config_t *config = dev->chip_info;</span><br><span> </span><br><span> rtc_init();</span><br><span>diff --git a/src/soc/intel/cannonlake/smmrelocate.c b/src/soc/intel/cannonlake/smmrelocate.c</span><br><span>index 20da625..83330e6 100644</span><br><span>--- a/src/soc/intel/cannonlake/smmrelocate.c</span><br><span>+++ b/src/soc/intel/cannonlake/smmrelocate.c</span><br><span>@@ -170,7 +170,7 @@</span><br><span> write_smrr(relo_params);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void fill_in_relocation_params(device_t dev,</span><br><span style="color: hsl(120, 100%, 40%);">+static void fill_in_relocation_params(struct device *dev,</span><br><span> struct smm_relocation_params *params)</span><br><span> {</span><br><span> void *handler_base;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26584">change 26584</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26584"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Iea56a6560bb23d48d19211304e57fc08e1c27fd6 </div>
<div style="display:none"> Gerrit-Change-Number: 26584 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>