[coreboot-gerrit] Change in coreboot[master]: intel/common/firmware: Add config to specify me_cleaner arguments

[Nicola Corna (Code Review)]

Nicola Corna has posted comments on this change. ( https://review.coreboot.org/26497 )

Change subject: intel/common/firmware: Add config to specify me_cleaner arguments
......................................................................


Patch Set 1:

I don't like this, we're just moving the burden of choosing the me_cleaner arguments to the user. Instead, why don't we hide CONFIG_ME_CLEANER_ARGUMENTS from the menuconfig, specify a default value (-S) and let the maintainer of each board override it? In your case, "-S -w MFS" should be applied to every librem board, it can be done automatically.

The 1% of users which needs specific me_cleaner args can just disable CONFIG_USE_ME_CLEANER and generate their ME image manually.


-- 
To view, visit https://review.coreboot.org/26497
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c39533ac07f517c1d652f1fb907be99eb62b836
Gerrit-Change-Number: 26497
Gerrit-PatchSet: 1
Gerrit-Owner: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: Nicola Corna <nicola at corna.info>
Gerrit-Reviewer: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 27 May 2018 12:50:44 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180527/5acc4ff9/attachment.html>