[coreboot-gerrit] Change in coreboot[master]: soc/intel/quark: Get rid of device_t

Elyes HAOUAS (Code Review) gerrit at coreboot.org
Fri May 25 13:16:38 CEST 2018


Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26542


Change subject: soc/intel/quark: Get rid of device_t
......................................................................

soc/intel/quark: Get rid of device_t

Use of device_t has been abandoned in ramstage.

Change-Id: I102c9b9b1066064589149388d5ebbcd6d0d81fa7
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/soc/intel/quark/chip.c
M src/soc/intel/quark/ehci.c
M src/soc/intel/quark/gpio_i2c.c
M src/soc/intel/quark/include/soc/ramstage.h
M src/soc/intel/quark/lpc.c
M src/soc/intel/quark/northcluster.c
M src/soc/intel/quark/spi.c
7 files changed, 8 insertions(+), 8 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/26542/1

diff --git a/src/soc/intel/quark/chip.c b/src/soc/intel/quark/chip.c
index 91ab8f5..2f8b826 100644
--- a/src/soc/intel/quark/chip.c
+++ b/src/soc/intel/quark/chip.c
@@ -121,7 +121,7 @@
 	fsp_silicon_init(romstage_handoff_is_resume());
 }
 
-static void pci_domain_set_resources(device_t dev)
+static void pci_domain_set_resources(struct device *dev)
 {
 	assign_resources(dev->link_list);
 }
@@ -132,7 +132,7 @@
 	.scan_bus	= pci_domain_scan_bus,
 };
 
-static void chip_enable_dev(device_t dev)
+static void chip_enable_dev(struct device *dev)
 {
 
 	/* Set the operations if it is a special bus type */
diff --git a/src/soc/intel/quark/ehci.c b/src/soc/intel/quark/ehci.c
index 2524fa7..1230629 100644
--- a/src/soc/intel/quark/ehci.c
+++ b/src/soc/intel/quark/ehci.c
@@ -107,7 +107,7 @@
 	REG_SCRIPT_END
 };
 
-static void init(device_t dev)
+static void init(struct device *dev)
 {
 	if ((dev->path.pci.devfn & 7) == EHCI_FUNC) {
 		printk(BIOS_INFO, "Initializing USB PLLs\n");
diff --git a/src/soc/intel/quark/gpio_i2c.c b/src/soc/intel/quark/gpio_i2c.c
index 1a9c5ae..100257b 100644
--- a/src/soc/intel/quark/gpio_i2c.c
+++ b/src/soc/intel/quark/gpio_i2c.c
@@ -24,7 +24,7 @@
 #include <soc/ramstage.h>
 #include <soc/reg_access.h>
 
-__weak void mainboard_gpio_i2c_init(device_t dev)
+__weak void mainboard_gpio_i2c_init(struct device *dev)
 {
 	/* Initialize any of the GPIOs or I2C devices */
 	printk(BIOS_SPEW, "WEAK; mainboard_gpio_i2c_init\n");
diff --git a/src/soc/intel/quark/include/soc/ramstage.h b/src/soc/intel/quark/include/soc/ramstage.h
index 9187487..4ad0fedc 100644
--- a/src/soc/intel/quark/include/soc/ramstage.h
+++ b/src/soc/intel/quark/include/soc/ramstage.h
@@ -24,7 +24,7 @@
 #endif
 #include <soc/QuarkNcSocId.h>
 
-void mainboard_gpio_i2c_init(device_t dev);
+void mainboard_gpio_i2c_init(struct device *dev);
 #if IS_ENABLED(CONFIG_PLATFORM_USES_FSP1_1)
 void fsp_silicon_init(bool s3wake);
 #endif
diff --git a/src/soc/intel/quark/lpc.c b/src/soc/intel/quark/lpc.c
index aefbaf6..809122b 100644
--- a/src/soc/intel/quark/lpc.c
+++ b/src/soc/intel/quark/lpc.c
@@ -22,7 +22,7 @@
 #include <soc/pm.h>
 #include <soc/ramstage.h>
 
-static void pmc_read_resources(device_t dev)
+static void pmc_read_resources(struct device *dev)
 {
 	unsigned int index = 0;
 	struct resource *res;
diff --git a/src/soc/intel/quark/northcluster.c b/src/soc/intel/quark/northcluster.c
index b52c3b7..124d767 100644
--- a/src/soc/intel/quark/northcluster.c
+++ b/src/soc/intel/quark/northcluster.c
@@ -24,7 +24,7 @@
 
 #define RES_IN_KIB(r) ((r) >> 10)
 
-static void nc_read_resources(device_t dev)
+static void nc_read_resources(struct device *dev)
 {
 	unsigned long base_k;
 	int index = 0;
diff --git a/src/soc/intel/quark/spi.c b/src/soc/intel/quark/spi.c
index 6c1aca9..4b011b7 100644
--- a/src/soc/intel/quark/spi.c
+++ b/src/soc/intel/quark/spi.c
@@ -232,7 +232,7 @@
 	uint32_t bios_control;
 	struct spi_context *context;
 	volatile struct flash_ctrlr *ctrlr;
-	device_t dev;
+	struct device *dev;
 	uint32_t rcba;
 
 	/* Determine the base address of the SPI flash controller */

-- 
To view, visit https://review.coreboot.org/26542
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I102c9b9b1066064589149388d5ebbcd6d0d81fa7
Gerrit-Change-Number: 26542
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180525/5ad9ff6d/attachment-0001.html>


More information about the coreboot-gerrit mailing list