[coreboot-gerrit] Change in coreboot[master]: drivers/intel/fsp2_0: Make use of malloc for FSP-S UPD

[Subrata Banik (Code Review)]

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/26501


Change subject: drivers/intel/fsp2_0: Make use of malloc for FSP-S UPD
......................................................................

drivers/intel/fsp2_0: Make use of malloc for FSP-S UPD

Don't allocate FSP-S UPD over stack. This patch to reduce stack
usage for Cannonlake platform.

Change-Id: I07ef0db6720d7e6865ac1641ce2661009332907c
Signed-off-by: Subrata Banik <subrata.banik at intel.com>
---
M src/drivers/intel/fsp2_0/silicon_init.c
1 file changed, 5 insertions(+), 6 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/26501/1

diff --git a/src/drivers/intel/fsp2_0/silicon_init.c b/src/drivers/intel/fsp2_0/silicon_init.c
index bda88d1..0ab7d86 100644
--- a/src/drivers/intel/fsp2_0/silicon_init.c
+++ b/src/drivers/intel/fsp2_0/silicon_init.c
@@ -26,7 +26,7 @@
 
 static void do_silicon_init(struct fsp_header *hdr)
 {
-	FSPS_UPD upd, *supd;
+	FSPS_UPD *upd = malloc(sizeof(FSPS_UPD)), *supd;
 	fsp_silicon_init_fn silicon_init;
 	uint32_t status;
 
@@ -34,20 +34,19 @@
 
 	if (supd->FspUpdHeader.Signature != FSPS_UPD_SIGNATURE)
 		die("Invalid FSPS signature\n");
-
-	memcpy(&upd, supd, sizeof(upd));
+	memcpy(upd, supd, sizeof(FSPS_UPD));
 
 	/* Give SoC/mainboard a chance to populate entries */
-	platform_fsp_silicon_init_params_cb(&upd);
+	platform_fsp_silicon_init_params_cb(upd);
 
 	/* Call SiliconInit */
 	silicon_init = (void *) (hdr->image_base +
 				 hdr->silicon_init_entry_offset);
-	fsp_debug_before_silicon_init(silicon_init, supd, &upd);
+	fsp_debug_before_silicon_init(silicon_init, supd, upd);
 
 	timestamp_add_now(TS_FSP_SILICON_INIT_START);
 	post_code(POST_FSP_SILICON_INIT);
-	status = silicon_init(&upd);
+	status = silicon_init(upd);
 	timestamp_add_now(TS_FSP_SILICON_INIT_END);
 	post_code(POST_FSP_SILICON_EXIT);
 

-- 
To view, visit https://review.coreboot.org/26501
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I07ef0db6720d7e6865ac1641ce2661009332907c
Gerrit-Change-Number: 26501
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180524/cc987703/attachment.html>