<p>Subrata Banik has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26501">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">drivers/intel/fsp2_0: Make use of malloc for FSP-S UPD<br><br>Don't allocate FSP-S UPD over stack. This patch to reduce stack<br>usage for Cannonlake platform.<br><br>Change-Id: I07ef0db6720d7e6865ac1641ce2661009332907c<br>Signed-off-by: Subrata Banik <subrata.banik@intel.com><br>---<br>M src/drivers/intel/fsp2_0/silicon_init.c<br>1 file changed, 5 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/26501/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/drivers/intel/fsp2_0/silicon_init.c b/src/drivers/intel/fsp2_0/silicon_init.c</span><br><span>index bda88d1..0ab7d86 100644</span><br><span>--- a/src/drivers/intel/fsp2_0/silicon_init.c</span><br><span>+++ b/src/drivers/intel/fsp2_0/silicon_init.c</span><br><span>@@ -26,7 +26,7 @@</span><br><span> </span><br><span> static void do_silicon_init(struct fsp_header *hdr)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- FSPS_UPD upd, *supd;</span><br><span style="color: hsl(120, 100%, 40%);">+  FSPS_UPD *upd = malloc(sizeof(FSPS_UPD)), *supd;</span><br><span>     fsp_silicon_init_fn silicon_init;</span><br><span>    uint32_t status;</span><br><span> </span><br><span>@@ -34,20 +34,19 @@</span><br><span> </span><br><span>       if (supd->FspUpdHeader.Signature != FSPS_UPD_SIGNATURE)</span><br><span>           die("Invalid FSPS signature\n");</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-      memcpy(&upd, supd, sizeof(upd));</span><br><span style="color: hsl(120, 100%, 40%);">+  memcpy(upd, supd, sizeof(FSPS_UPD));</span><br><span> </span><br><span>     /* Give SoC/mainboard a chance to populate entries */</span><br><span style="color: hsl(0, 100%, 40%);">-   platform_fsp_silicon_init_params_cb(&upd);</span><br><span style="color: hsl(120, 100%, 40%);">+        platform_fsp_silicon_init_params_cb(upd);</span><br><span> </span><br><span>        /* Call SiliconInit */</span><br><span>       silicon_init = (void *) (hdr->image_base +</span><br><span>                                 hdr->silicon_init_entry_offset);</span><br><span style="color: hsl(0, 100%, 40%);">-    fsp_debug_before_silicon_init(silicon_init, supd, &upd);</span><br><span style="color: hsl(120, 100%, 40%);">+  fsp_debug_before_silicon_init(silicon_init, supd, upd);</span><br><span> </span><br><span>  timestamp_add_now(TS_FSP_SILICON_INIT_START);</span><br><span>        post_code(POST_FSP_SILICON_INIT);</span><br><span style="color: hsl(0, 100%, 40%);">-       status = silicon_init(&upd);</span><br><span style="color: hsl(120, 100%, 40%);">+      status = silicon_init(upd);</span><br><span>  timestamp_add_now(TS_FSP_SILICON_INIT_END);</span><br><span>  post_code(POST_FSP_SILICON_EXIT);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26501">change 26501</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26501"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I07ef0db6720d7e6865ac1641ce2661009332907c </div>
<div style="display:none"> Gerrit-Change-Number: 26501 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> </div>