[coreboot-gerrit] Change in coreboot[master]: nb/via/vx800: Get rid of device_t

Elyes HAOUAS (Code Review) gerrit at coreboot.org
Sun May 20 11:00:30 CEST 2018


Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26425


Change subject: nb/via/vx800: Get rid of device_t
......................................................................

nb/via/vx800: Get rid of device_t

Use of device_t has been abandoned in ramstage.

Change-Id: Ib432d3c3ce2788b0138a1b0e852385ab4f9b65ee
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/northbridge/via/vx800/lpc.c
M src/northbridge/via/vx800/northbridge.c
M src/northbridge/via/vx800/vga.c
3 files changed, 10 insertions(+), 10 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/26425/1

diff --git a/src/northbridge/via/vx800/lpc.c b/src/northbridge/via/vx800/lpc.c
index 1ab11c0..93413a2 100644
--- a/src/northbridge/via/vx800/lpc.c
+++ b/src/northbridge/via/vx800/lpc.c
@@ -94,7 +94,7 @@
 	printk(BIOS_SPEW, "%s: DONE\n", __FUNCTION__);
 }
 
-static void setup_pm(device_t dev)
+static void setup_pm(struct device *dev)
 {
 	u16 tmp;
 	/* Debounce LID and PWRBTN# Inputs for 16ms. */
@@ -274,7 +274,7 @@
 
 /* total kludge to get lxb to call our childrens set/enable functions - these are
    not called unless this device has a resource to set - so set a dummy one */
-static void vx800_read_resources(device_t dev)
+static void vx800_read_resources(struct device *dev)
 {
 
 	struct resource *resource;
@@ -287,7 +287,7 @@
 	resource->base = 0x2e;
 }
 
-static void vx800_set_resources(device_t dev)
+static void vx800_set_resources(struct device *dev)
 {
 	struct resource *resource;
 	resource = find_resource(dev, 1);
diff --git a/src/northbridge/via/vx800/northbridge.c b/src/northbridge/via/vx800/northbridge.c
index 609abf8..2f1ddc1 100644
--- a/src/northbridge/via/vx800/northbridge.c
+++ b/src/northbridge/via/vx800/northbridge.c
@@ -33,7 +33,7 @@
 /* !!FIXME!!  I declared this to fix the build. */
 u8 acpi_sleep_type = 0;
 
-static void memctrl_init(device_t dev)
+static void memctrl_init(struct device *dev)
 {
 /*
   set VGA in uma_ram_setting.c, not in this function.
@@ -51,13 +51,13 @@
 	.device = PCI_DEVICE_ID_VIA_VX855_MEMCTRL,
 };
 
-static void pci_domain_set_resources(device_t dev)
+static void pci_domain_set_resources(struct device *dev)
 {
 	/*
 	 * the order is important to find the correct RAM size.
 	 */
 	u8 ramregs[] = { 0x43, 0x42, 0x41, 0x40 };
-	device_t mc_dev;
+	struct device *mc_dev;
 	u32 pci_tolm;
 	u8 reg;
 
@@ -124,7 +124,7 @@
 	.scan_bus = pci_domain_scan_bus,
 };
 
-static void cpu_bus_init(device_t dev)
+static void cpu_bus_init(struct device *dev)
 {
 	initialize_cpus(dev->link_list);
 }
diff --git a/src/northbridge/via/vx800/vga.c b/src/northbridge/via/vx800/vga.c
index 4109f62..447c762 100644
--- a/src/northbridge/via/vx800/vga.c
+++ b/src/northbridge/via/vx800/vga.c
@@ -72,7 +72,7 @@
 		 * N:  Frame Buffer Size 2^N  MB
 		 */
 		u8 i;
-		device_t dev;
+		struct device *dev;
 		dev = dev_find_slot(0, PCI_DEVFN(0, 3));
 		i = pci_read_config8(dev, 0xa1);
 		i = (i & 0x70);
@@ -124,7 +124,7 @@
 #ifdef UNUSED_CODE
 static void write_protect_vgabios(void)
 {
-	device_t dev;
+	struct device *dev;
 
 	printk(BIOS_INFO, "write_protect_vgabios\n");
 	/* there are two possible devices. Just do both. */
@@ -149,7 +149,7 @@
 }
 
 extern u8 acpi_sleep_type;
-static void vga_init(device_t dev)
+static void vga_init(struct device *dev)
 {
 	uint8_t reg8;
 

-- 
To view, visit https://review.coreboot.org/26425
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib432d3c3ce2788b0138a1b0e852385ab4f9b65ee
Gerrit-Change-Number: 26425
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180520/6a3e3c6a/attachment.html>


More information about the coreboot-gerrit mailing list