[coreboot-gerrit] Change in coreboot[master]: intel/skylake: nhlt: Update Max98373's capture format

Sathyanarayana Nujella (Code Review) gerrit at coreboot.org
Fri May 18 20:43:24 CEST 2018


Sathyanarayana Nujella has uploaded this change for review. ( https://review.coreboot.org/26384


Change subject: intel/skylake: nhlt: Update Max98373's capture format
......................................................................

intel/skylake: nhlt: Update Max98373's capture format

Max98373's NHLT capture configuration is used for IV feedback for
DSM algorithm.
Feedback is 4-channel data. Without this configuration below error
is seen in dmesg:

[  315.784250] snd_soc_skl 0000:00:1f.3: Blob NULL for id 0 type 3 dirn 1
[  315.784263] snd_soc_skl 0000:00:1f.3: PCM: ch 4, freq 48000, fmt 32

So, update nhlt configuration accordingly.

BUG=b:79362472
TEST=Audio playback works with IV feedback enabled

Change-Id: I75434a63fe030ed9bb963c6d300d833a8e7d2d66
Signed-off-by: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
---
M src/soc/intel/skylake/nhlt/max98373.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/26384/1

diff --git a/src/soc/intel/skylake/nhlt/max98373.c b/src/soc/intel/skylake/nhlt/max98373.c
index 6d357f6..7d01b92 100644
--- a/src/soc/intel/skylake/nhlt/max98373.c
+++ b/src/soc/intel/skylake/nhlt/max98373.c
@@ -39,9 +39,9 @@
 static const struct nhlt_format_config max98373_capture_formats[] = {
 	/* 48 KHz 16-bits per sample. */
 	{
-		.num_channels = 2,
+		.num_channels = 4,
 		.sample_freq_khz = 48,
-		.container_bits_per_sample = 16,
+		.container_bits_per_sample = 32,
 		.valid_bits_per_sample = 16,
 		.speaker_mask = SPEAKER_FRONT_LEFT | SPEAKER_FRONT_RIGHT,
 		.settings_file = "max98373-render-2ch-48khz-16b.bin",

-- 
To view, visit https://review.coreboot.org/26384
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I75434a63fe030ed9bb963c6d300d833a8e7d2d66
Gerrit-Change-Number: 26384
Gerrit-PatchSet: 1
Gerrit-Owner: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180518/afc60f4b/attachment.html>


More information about the coreboot-gerrit mailing list