<p>Sathyanarayana Nujella has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26384">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">intel/skylake: nhlt: Update Max98373's capture format<br><br>Max98373's NHLT capture configuration is used for IV feedback for<br>DSM algorithm.<br>Feedback is 4-channel data. Without this configuration below error<br>is seen in dmesg:<br><br>[  315.784250] snd_soc_skl 0000:00:1f.3: Blob NULL for id 0 type 3 dirn 1<br>[  315.784263] snd_soc_skl 0000:00:1f.3: PCM: ch 4, freq 48000, fmt 32<br><br>So, update nhlt configuration accordingly.<br><br>BUG=b:79362472<br>TEST=Audio playback works with IV feedback enabled<br><br>Change-Id: I75434a63fe030ed9bb963c6d300d833a8e7d2d66<br>Signed-off-by: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com><br>---<br>M src/soc/intel/skylake/nhlt/max98373.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/26384/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/skylake/nhlt/max98373.c b/src/soc/intel/skylake/nhlt/max98373.c</span><br><span>index 6d357f6..7d01b92 100644</span><br><span>--- a/src/soc/intel/skylake/nhlt/max98373.c</span><br><span>+++ b/src/soc/intel/skylake/nhlt/max98373.c</span><br><span>@@ -39,9 +39,9 @@</span><br><span> static const struct nhlt_format_config max98373_capture_formats[] = {</span><br><span>       /* 48 KHz 16-bits per sample. */</span><br><span>     {</span><br><span style="color: hsl(0, 100%, 40%);">-               .num_channels = 2,</span><br><span style="color: hsl(120, 100%, 40%);">+            .num_channels = 4,</span><br><span>           .sample_freq_khz = 48,</span><br><span style="color: hsl(0, 100%, 40%);">-          .container_bits_per_sample = 16,</span><br><span style="color: hsl(120, 100%, 40%);">+              .container_bits_per_sample = 32,</span><br><span>             .valid_bits_per_sample = 16,</span><br><span>                 .speaker_mask = SPEAKER_FRONT_LEFT | SPEAKER_FRONT_RIGHT,</span><br><span>            .settings_file = "max98373-render-2ch-48khz-16b.bin",</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26384">change 26384</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26384"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I75434a63fe030ed9bb963c6d300d833a8e7d2d66 </div>
<div style="display:none"> Gerrit-Change-Number: 26384 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com> </div>