[coreboot-gerrit] Change in coreboot[master]: google/kahlee: Swap UNIFIED_MRC_CACHE and RW_SECTION_A in fwmap

[Daniel Kurtz (Code Review)]

Hello Daniel Kurtz,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/26356

to review the following change.


Change subject: google/kahlee: Swap UNIFIED_MRC_CACHE and RW_SECTION_A in fwmap
......................................................................

google/kahlee: Swap UNIFIED_MRC_CACHE and RW_SECTION_A in fwmap

The firmware_Mosys FAFT test does not allow RW_SECTION_A, RW_SECTION_B or
RW_SHARED to be 0-sized, nor located at offset 0x00000000.

Swap UNIFIED_MRC_CACHE and RW_SECTION_A to pass this test.

BUG=b:79865447
TEST=test_that -b grunt ${IP} firmware_Mosys

Change-Id: If60919fd998ac786d58a5a258d7b5ded727db64b
Signed-off-by: Daniel Kurtz <djkurtz at chromium.org>
---
M src/mainboard/google/kahlee/variants/grunt/chromeos.fmd
1 file changed, 7 insertions(+), 7 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/26356/1

diff --git a/src/mainboard/google/kahlee/variants/grunt/chromeos.fmd b/src/mainboard/google/kahlee/variants/grunt/chromeos.fmd
index 11c4bf0..749546d 100644
--- a/src/mainboard/google/kahlee/variants/grunt/chromeos.fmd
+++ b/src/mainboard/google/kahlee/variants/grunt/chromeos.fmd
@@ -1,20 +1,20 @@
 FLASH at 0xFF000000 0x1000000 {
 	SI_BIOS at 0x0 0x1000000 {
-		RW_SECTION_A at 0x0 0x21E000 {
+		UNIFIED_MRC_CACHE at 0x0 0x21000 {
+			RECOVERY_MRC_CACHE at 0x0 0x10000
+			RW_MRC_CACHE at 0x10000 0x10000
+			RW_VAR_MRC_CACHE at 0x20000 0x1000
+		}
+		RW_SECTION_A at 0x21000 0x21E000 {
 			VBLOCK_A at 0x0 0x10000
 			FW_MAIN_A(CBFS)@0x10000 0x20DFC0
 			RW_FWID_A at 0x21DFC0 0x40
 		}
-		RW_SECTION_B at 0x21E000 0x21E000 {
+		RW_SECTION_B at 0x23F000 0x21E000 {
 			VBLOCK_B at 0x0 0x10000
 			FW_MAIN_B(CBFS)@0x10000 0x20DFC0
 			RW_FWID_B at 0x21DFC0 0x40
 		}
-		UNIFIED_MRC_CACHE at 0x43C000 0x21000 {
-			RECOVERY_MRC_CACHE at 0x0 0x10000
-			RW_MRC_CACHE at 0x10000 0x10000
-			RW_VAR_MRC_CACHE at 0x20000 0x1000
-		}
 		RW_ELOG at 0x45D000 0x4000
 
 		RW_SHARED at 0x461000 0x4000 {

-- 
To view, visit https://review.coreboot.org/26356
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If60919fd998ac786d58a5a258d7b5ded727db64b
Gerrit-Change-Number: 26356
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180517/8f461edb/attachment.html>