<p>Daniel Kurtz would like Daniel Kurtz to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/26356">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">google/kahlee: Swap UNIFIED_MRC_CACHE and RW_SECTION_A in fwmap<br><br>The firmware_Mosys FAFT test does not allow RW_SECTION_A, RW_SECTION_B or<br>RW_SHARED to be 0-sized, nor located at offset 0x00000000.<br><br>Swap UNIFIED_MRC_CACHE and RW_SECTION_A to pass this test.<br><br>BUG=b:79865447<br>TEST=test_that -b grunt ${IP} firmware_Mosys<br><br>Change-Id: If60919fd998ac786d58a5a258d7b5ded727db64b<br>Signed-off-by: Daniel Kurtz <djkurtz@chromium.org><br>---<br>M src/mainboard/google/kahlee/variants/grunt/chromeos.fmd<br>1 file changed, 7 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/26356/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/kahlee/variants/grunt/chromeos.fmd b/src/mainboard/google/kahlee/variants/grunt/chromeos.fmd</span><br><span>index 11c4bf0..749546d 100644</span><br><span>--- a/src/mainboard/google/kahlee/variants/grunt/chromeos.fmd</span><br><span>+++ b/src/mainboard/google/kahlee/variants/grunt/chromeos.fmd</span><br><span>@@ -1,20 +1,20 @@</span><br><span> FLASH@0xFF000000 0x1000000 {</span><br><span>        SI_BIOS@0x0 0x1000000 {</span><br><span style="color: hsl(0, 100%, 40%);">-         RW_SECTION_A@0x0 0x21E000 {</span><br><span style="color: hsl(120, 100%, 40%);">+           UNIFIED_MRC_CACHE@0x0 0x21000 {</span><br><span style="color: hsl(120, 100%, 40%);">+                       RECOVERY_MRC_CACHE@0x0 0x10000</span><br><span style="color: hsl(120, 100%, 40%);">+                        RW_MRC_CACHE@0x10000 0x10000</span><br><span style="color: hsl(120, 100%, 40%);">+                  RW_VAR_MRC_CACHE@0x20000 0x1000</span><br><span style="color: hsl(120, 100%, 40%);">+               }</span><br><span style="color: hsl(120, 100%, 40%);">+             RW_SECTION_A@0x21000 0x21E000 {</span><br><span>                      VBLOCK_A@0x0 0x10000</span><br><span>                         FW_MAIN_A(CBFS)@0x10000 0x20DFC0</span><br><span>                     RW_FWID_A@0x21DFC0 0x40</span><br><span>              }</span><br><span style="color: hsl(0, 100%, 40%);">-               RW_SECTION_B@0x21E000 0x21E000 {</span><br><span style="color: hsl(120, 100%, 40%);">+              RW_SECTION_B@0x23F000 0x21E000 {</span><br><span>                     VBLOCK_B@0x0 0x10000</span><br><span>                         FW_MAIN_B(CBFS)@0x10000 0x20DFC0</span><br><span>                     RW_FWID_B@0x21DFC0 0x40</span><br><span>              }</span><br><span style="color: hsl(0, 100%, 40%);">-               UNIFIED_MRC_CACHE@0x43C000 0x21000 {</span><br><span style="color: hsl(0, 100%, 40%);">-                    RECOVERY_MRC_CACHE@0x0 0x10000</span><br><span style="color: hsl(0, 100%, 40%);">-                  RW_MRC_CACHE@0x10000 0x10000</span><br><span style="color: hsl(0, 100%, 40%);">-                    RW_VAR_MRC_CACHE@0x20000 0x1000</span><br><span style="color: hsl(0, 100%, 40%);">-         }</span><br><span>            RW_ELOG@0x45D000 0x4000</span><br><span> </span><br><span>          RW_SHARED@0x461000 0x4000 {</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26356">change 26356</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26356"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: If60919fd998ac786d58a5a258d7b5ded727db64b </div>
<div style="display:none"> Gerrit-Change-Number: 26356 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Daniel Kurtz <djkurtz@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Daniel Kurtz <djkurtz@chromium.org> </div>