[coreboot-gerrit] Change in coreboot[master]: src/device: Remove space after sizeof

Elyes HAOUAS (Code Review) gerrit at coreboot.org
Wed May 16 13:00:58 CEST 2018


Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26322


Change subject: src/device: Remove space after sizeof
......................................................................

src/device: Remove space after sizeof

Change-Id: Ic8b77c78739badbea398053944484a55f715d03d
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/device/device_util.c
M src/device/oprom/x86emu/debug.c
2 files changed, 17 insertions(+), 17 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/26322/1

diff --git a/src/device/device_util.c b/src/device/device_util.c
index aad3b4b..3f65b67 100644
--- a/src/device/device_util.c
+++ b/src/device/device_util.c
@@ -288,60 +288,60 @@
 			memcpy(buffer, "Root Device", 12);
 			break;
 		case DEVICE_PATH_PCI:
-			snprintf(buffer, sizeof (buffer),
+			snprintf(buffer, sizeof(buffer),
 				 "PCI: %02x:%02x.%01x",
 				 dev->bus->secondary,
 				 PCI_SLOT(dev->path.pci.devfn),
 				 PCI_FUNC(dev->path.pci.devfn));
 			break;
 		case DEVICE_PATH_PNP:
-			snprintf(buffer, sizeof (buffer), "PNP: %04x.%01x",
+			snprintf(buffer, sizeof(buffer), "PNP: %04x.%01x",
 				 dev->path.pnp.port, dev->path.pnp.device);
 			break;
 		case DEVICE_PATH_I2C:
-			snprintf(buffer, sizeof (buffer), "I2C: %02x:%02x",
+			snprintf(buffer, sizeof(buffer), "I2C: %02x:%02x",
 				 dev->bus->secondary,
 				 dev->path.i2c.device);
 			break;
 		case DEVICE_PATH_APIC:
-			snprintf(buffer, sizeof (buffer), "APIC: %02x",
+			snprintf(buffer, sizeof(buffer), "APIC: %02x",
 				 dev->path.apic.apic_id);
 			break;
 		case DEVICE_PATH_IOAPIC:
-			snprintf(buffer, sizeof (buffer), "IOAPIC: %02x",
+			snprintf(buffer, sizeof(buffer), "IOAPIC: %02x",
 				 dev->path.ioapic.ioapic_id);
 			break;
 		case DEVICE_PATH_DOMAIN:
-			snprintf(buffer, sizeof (buffer), "DOMAIN: %04x",
+			snprintf(buffer, sizeof(buffer), "DOMAIN: %04x",
 				dev->path.domain.domain);
 			break;
 		case DEVICE_PATH_CPU_CLUSTER:
-			snprintf(buffer, sizeof (buffer), "CPU_CLUSTER: %01x",
+			snprintf(buffer, sizeof(buffer), "CPU_CLUSTER: %01x",
 				dev->path.cpu_cluster.cluster);
 			break;
 		case DEVICE_PATH_CPU:
-			snprintf(buffer, sizeof (buffer),
+			snprintf(buffer, sizeof(buffer),
 				 "CPU: %02x", dev->path.cpu.id);
 			break;
 		case DEVICE_PATH_CPU_BUS:
-			snprintf(buffer, sizeof (buffer),
+			snprintf(buffer, sizeof(buffer),
 				 "CPU_BUS: %02x", dev->path.cpu_bus.id);
 			break;
 		case DEVICE_PATH_GENERIC:
-			snprintf(buffer, sizeof (buffer),
+			snprintf(buffer, sizeof(buffer),
 				 "GENERIC: %d.%d", dev->path.generic.id,
 				 dev->path.generic.subid);
 			break;
 		case DEVICE_PATH_SPI:
-			snprintf(buffer, sizeof (buffer), "SPI: %02x",
+			snprintf(buffer, sizeof(buffer), "SPI: %02x",
 				 dev->path.spi.cs);
 			break;
 		case DEVICE_PATH_USB:
-			snprintf(buffer, sizeof (buffer), "USB%u port %u",
+			snprintf(buffer, sizeof(buffer), "USB%u port %u",
 				 dev->path.usb.port_type, dev->path.usb.port_id);
 			break;
 		case DEVICE_PATH_MMIO:
-			snprintf(buffer, sizeof (buffer), "MMIO: %08x",
+			snprintf(buffer, sizeof(buffer), "MMIO: %08x",
 				 dev->path.mmio.addr);
 			break;
 		default:
@@ -366,7 +366,7 @@
 const char *bus_path(struct bus *bus)
 {
 	static char buffer[BUS_PATH_MAX];
-	snprintf(buffer, sizeof (buffer),
+	snprintf(buffer, sizeof(buffer),
 		 "%s,%d", dev_path(bus->dev), bus->link_num);
 	return buffer;
 }
@@ -670,7 +670,7 @@
 const char *resource_type(struct resource *resource)
 {
 	static char buffer[RESOURCE_TYPE_MAX];
-	snprintf(buffer, sizeof (buffer), "%s%s%s%s",
+	snprintf(buffer, sizeof(buffer), "%s%s%s%s",
 		 ((resource->flags & IORESOURCE_READONLY) ? "ro" : ""),
 		 ((resource->flags & IORESOURCE_PREFETCH) ? "pref" : ""),
 		 ((resource->flags == 0) ? "unused" :
@@ -703,7 +703,7 @@
 	buf[0] = '\0';
 
 	if (resource->flags & IORESOURCE_PCI_BRIDGE) {
-		snprintf(buf, sizeof (buf),
+		snprintf(buf, sizeof(buf),
 			 "bus %02x ", dev->link_list->secondary);
 	}
 	printk(BIOS_DEBUG, "%s %02lx <- [0x%010llx - 0x%010llx] size 0x%08llx "
diff --git a/src/device/oprom/x86emu/debug.c b/src/device/oprom/x86emu/debug.c
index 9e216e9..ab55198 100644
--- a/src/device/oprom/x86emu/debug.c
+++ b/src/device/oprom/x86emu/debug.c
@@ -170,7 +170,7 @@
 void x86emu_decode_printf2 (const char *x, int y)
 {
     char temp[100];
-    snprintf(temp, sizeof (temp), x,y);
+    snprintf(temp, sizeof(temp), x,y);
     strcpy(M.x86.decoded_buf+M.x86.enc_str_pos,temp);
     M.x86.enc_str_pos += strlen(temp);
 }

-- 
To view, visit https://review.coreboot.org/26322
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic8b77c78739badbea398053944484a55f715d03d
Gerrit-Change-Number: 26322
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180516/588d1527/attachment.html>


More information about the coreboot-gerrit mailing list